[ENG-7287] fix onedrive auth headers for download/upload requests#415
Closed
[ENG-7287] fix onedrive auth headers for download/upload requests#415
Conversation
* Some OneDrive endpoints return a 401 error if the `Authorization`
header is included with a signed request. This depends on the
individual host serving the request, but we'll go ahead and turn it
off for all. Context:
* MS API documentation for chunked_upload requests:
https://learn.microsoft.com/en-us/graph/api/driveitem-createuploadsession?view=graph-rest-1.0#remarks
* Rclone fix for the upload endpoint:
rclone/rclone@dedad9f
* Rclone fix for the download endpoint:
rclone/rclone@aee8d90
[ENG-7287]
* Replace with `actions/cache@v4`. No other changes needed?
brianjgeiger
approved these changes
Feb 21, 2025
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-7287
Purpose
Fix some downloads and uploads to OneDrive. Depending on the host that serves the request, some OD requests get mad if you include an
Authorizationheader with a signed request and return a401. Stop doing that.Changes
cache@v4.cache@v2is deprecated and will stop working on March 1, 2025.Side effects
Hopefully no?
QA Notes
Dev tested on staging!
Deployment Notes
Nope.