Skip to content

[ENG-8251] | Fix failing move/copy task tests #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felliott merged 1 commit into from
Jul 8, 2025
Merged

[ENG-8251] | Fix failing move/copy task tests #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tests/tasks/test_copy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def make_provider(name=None, **kwargs):
return src_provider, dest_provider


@pytest.mark.skip('TODO: test fails sometimes')
@pytest.mark.celery(result_backend=None)
def test_copy_calls_copy(providers, bundles, callback):
src, dest = providers
Expand All @@ -62,7 +61,6 @@ def test_is_task():
assert not asyncio.iscoroutine(copy.copy)
assert asyncio.iscoroutinefunction(copy.copy.adelay)

@pytest.mark.skip('TODO: test fails sometimes')
@pytest.mark.celery(result_backend=None)
def test_imputes_exceptions(providers, bundles, callback):
src, dest = providers
Expand All @@ -82,7 +80,6 @@ def test_imputes_exceptions(providers, bundles, callback):
assert method == 'PUT'
assert data['errors'] == ["Exception('This is a string')"]

@pytest.mark.skip('TODO: test fails sometimes')
@pytest.mark.celery(result_backend=None)
def test_return_values(providers, bundles, callback, src_path, dest_path, mock_time, FAKE_TIME):
src, dest = providers
Expand Down Expand Up @@ -136,7 +133,6 @@ def test_return_values(providers, bundles, callback, src_path, dest_path, mock_t
'sizeInt': metadata.size_as_int,
}

@pytest.mark.skip('TODO: test fails sometimes')
@pytest.mark.celery(result_backend=None)
def test_starttime_override(providers, bundles, callback, mock_time, FAKE_TIME):
src, dest = providers
Expand Down
4 changes: 0 additions & 4 deletions tests/tasks/test_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def make_provider(name=None, **kwargs):
return src_provider, dest_provider


@pytest.mark.skip('TODO: test fails sometimes')
@pytest.mark.celery(result_backend=None)
def test_move_calls_move(providers, bundles, callback):
src, dest = providers
Expand All @@ -64,7 +63,6 @@ def test_is_task():
assert asyncio.iscoroutinefunction(move.move.adelay)


@pytest.mark.skip('TODO: test fails sometimes')
@pytest.mark.celery(result_backend=None)
def test_imputes_exceptions(providers, bundles, callback):
src, dest = providers
Expand All @@ -85,7 +83,6 @@ def test_imputes_exceptions(providers, bundles, callback):
assert url == 'dest_callback'


@pytest.mark.skip('TODO: test fails sometimes')
@pytest.mark.celery(result_backend=None)
def test_return_values(providers, bundles, callback, src_path, dest_path, mock_time, FAKE_TIME):
src, dest = providers
Expand Down Expand Up @@ -140,7 +137,6 @@ def test_return_values(providers, bundles, callback, src_path, dest_path, mock_t
}


@pytest.mark.skip('TODO: test fails sometimes')
@pytest.mark.celery(result_backend=None)
def test_starttime_override(providers, bundles, callback, mock_time, FAKE_TIME):
src, dest = providers
Expand Down