[ENG-8563] Download of QA owncloud file results in 502 Gateway error#467
Closed
mkovalua wants to merge 14 commits intoCenterForOpenScience:post-buff-wormsfrom
Closed
[ENG-8563] Download of QA owncloud file results in 502 Gateway error#467mkovalua wants to merge 14 commits intoCenterForOpenScience:post-buff-wormsfrom
mkovalua wants to merge 14 commits intoCenterForOpenScience:post-buff-wormsfrom
Conversation
* (Signature of method X does not match signature of base method Y of the base) CenterForOpenScience#463 (comment)
* method signature does not match overridden CenterForOpenScience#463 (comment)
* add extra note about alternative implementation of some methods for s3 provider CenterForOpenScience#463 (comment)
* S3 tests are skipped because request signing and client interaction have changed significantly on boto to boto3 migration, breaking the old test logic CenterForOpenScience#463 (comment)
* with new one test fails with the following error # FAILED tests/server/api/v1/test_core.py::TestBaseHandler::test_write_error # - TypeError: BaseHandler.write_error() takes 2 positional arguments but 3 were given maybe it cause additional issues (though old and new 'write_error' code looks to have same logic) even though we align test
* pytest_runtest_setup and pytest_runtest_teardown is not used on test suite run for now, it looks to be redundant CenterForOpenScience#463 (comment)
* owncloud gzips some file types (yml, json). Send the Accept-Encoding: identity header allow to return actual file size not archived to read it properly * update owncloud test_download_range to work with new download headers changes
felliott
force-pushed
the
fix/ENG--8563
branch
from
9058c3a to
57792e5
Compare
Member
|
This has been merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8563
Purpose
Download of QA owncloud file results in 502 Gateway error
Changes
owncloud use gzip for some file types (yml, json), allow to return actual file size not archived to read it properly by adding
headers={'Accept-Encoding': 'identity'}Screen.Recording.2025-08-14.at.15.53.01.1.mp4
<CIMultiDictProxy('Server': 'nginx', 'Date': 'Thu, 14 Aug 2025 12:49:48 GMT', 'Content-Type': 'text/plain;charset=UTF-8', 'Content-Length': '17926', 'Connection': 'keep-alive', 'X-Content-Type-Options': 'nosniff', 'X-XSS-Protection': '0', 'X-Robots-Tag': 'none', 'X-Frame-Options': 'SAMEORIGIN', 'X-Download-Options': 'noopen', 'X-Permitted-Cross-Domain-Policies': 'none', 'Expires': 'Thu, 19 Nov 1981 08:52:00 GMT', 'Cache-Control': 'no-store, no-cache, must-revalidate', 'Pragma': 'no-cache', 'Set-Cookie': 'oc_sessionPassphrase=FE60xqc6HURDD3sKesZTSnt5OFgHAvcqSiSiIA%2FVQpSBfQDL77UdxR5AIrQYgUm1xR3MmXGRoESimXygBXK%2BeXukCBExQm1WBMKddrDf%2FoEOb3b6dityYGbqrOQTNpp4; expires=Thu, 14-Aug-2025 13:09:48 GMT; Max-Age=1200; path=/; secure; HttpOnly; SameSite=None', 'Content-Security-Policy': "default-src 'none';", 'Last-Modified': 'Thu, 14 Aug 2025 11:13:35 GMT', 'Etag': '"79fcfbb494bbc2f6d284c9dfc47a5f76"', 'OC-ETag': '"79fcfbb494bbc2f6d284c9dfc47a5f76"', 'Content-Disposition': 'attachment; filename*=UTF-8\'\'docker-compose%20%285%29.yml; filename="docker-compose%20%285%29.yml"', 'OC-Checksum': 'SHA1:63a30fa9f8c0bb381f4e34bc0912a13bdc5e2e3d', 'Vary': 'Accept-Encoding', 'Strict-Transport-Security': 'max-age=15552000; includeSubDomains')>Side effects
QA Notes
Deployment Notes