Implement tracing Gc with rust-gc #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is currently not possible to implement recursive type, so all tracing is noop here Signed-off-by: Yaroslav Bolyukin <[email protected]>
AST can't have cycles, so tracing is noop here Signed-off-by: Yaroslav Bolyukin <[email protected]>
Interned string is backed by Rc<str>, there is nothing to trace here Signed-off-by: Yaroslav Bolyukin <[email protected]>
Some manual Trace/Finalize implementations can be replaced with derives with Manishearth/rust-gc#116 getting merged Signed-off-by: Yaroslav Bolyukin <[email protected]>
It will build, but some methods is broken for now Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
JarvisCraft
requested changes
Jun 5, 2021
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Property __intrinsic_namespace__ shouldn't be handled by anyone Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Signed-off-by: Yaroslav Bolyukin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bellow issues were fixed by forking rust-gc into https://github.com/CertainLach/jrsonnet-gc