Conversation
caballa
reviewed
Mar 12, 2025
| @@ -1,15 +0,0 @@ | |||
| diff --git a/compiler/rustc_codegen_llvm/src/type_.rs b/compiler/rustc_codegen_llvm/src/type_.rs | |||
Collaborator
There was a problem hiding this comment.
so this patch isn't needed anymore?
Collaborator
Author
There was a problem hiding this comment.
yes, this patch was reverting using vectors to copy rust values. This was also reverted in newer versions of Rust, making our patch unnecessary.
caballa
approved these changes
Mar 12, 2025
Collaborator
caballa
left a comment
caballa
left a comment
There was a problem hiding this comment.
LGTM.
But we shouldn't merge it until we can test it, right?
Collaborator
Author
|
Yes, don't merge it yet. I was hoping the workflow will run and build the platform tools that we can share, but looks like workflow is not enabled on PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.