Update TilesetViewGroup to have information about their associated credits #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is referenced or not
…uce new referencer for raster overlay credits;
Contributor
|
Thanks @ludovic-cheval-bentley-systems for opening this PR! @kring do you mind taking a look? |
Contributor
|
Just realized this PR is still marked as draft; @ludovic-cheval-bentley-systems let us know when it's officially ready for review. |
Member
|
@ludovic-cheval-bentley-systems now that this is passing CI, go ahead and hit that "Ready for review" button and we'll take a look. Unless there is more you want to do with it first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By calling getSnapshot on a CreditSystem, clients can retrieve the current set of active credits. However, this snapshot represents credits across all TilesetViewGroups.
Some clients need to display credits separately for each viewport. To support this, new isCreditReferenced methods have been added to both CreditReferencer and TilesetViewGroup. These allow clients to check whether credits obtained from the CreditSystem apply to a specific TilesetViewGroup.
Similarly, certain clients must distinguish credits originating from raster overlays from other credits. To enable this, a dedicated CreditReferencer has been introduced within TilesetViewGroup to reference raster overlay credits. The existing CreditReferencer continues to reference all credits associated with the TilesetViewGroup.