Fix updateViewGroupOffline() so that it doesn't hang#1336
Merged
j9liu merged 2 commits intoCesiumGS:mainfrom Mar 31, 2026
Merged
Fix updateViewGroupOffline() so that it doesn't hang#1336j9liu merged 2 commits intoCesiumGS:mainfrom
j9liu merged 2 commits intoCesiumGS:mainfrom
Conversation
j9liu
reviewed
Mar 30, 2026
Contributor
j9liu
left a comment
There was a problem hiding this comment.
Thank you so much @ELeeScape! Can I trouble you to format the TestTilesetSelectionAlgorithm.cpp class for CI to pass? You can do this with npm by doing:
npm install
npm run format
Otherwise, these changes look great! I'm just reproducing the error locally to confirm the fix (per our reviewer checklist).
Contributor
Author
|
@j9liu Formatting done. |
Contributor
|
Thank you so much @ELeeScape! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tileset::updateViewGroupOffline() was hanging because it calls updateViewGroup() and loadTiles() in a loop without dispatching main thread tasks. This was a regression resulting from #1315.
Added main thread dispatches to updateViewGroupOffline() before every call to updateViewGroup() and loadTiles() and added a test to demonstrate the fix.
Also made the same fix for the deprecated updateView() function. There are no existing tests for updateView() so I didn't add one.
Issue number or link
Fixes #1335.
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Testing plan
The new test subcase "updateViewGroupOffline does its own dispatching of main thread tasks so it doesn't get stuck" hangs without the fix, passes with the fix.
Reviewer checklist
Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.
As you review, please go through the checklist below:
CHANGES.mdto make sure they accurately cover the work in this PR.