Add Tileset::sampleHeightCurrentDetail() to sample terrain height based on the currently loaded tiles#1338
Open
ELeeScape wants to merge 1 commit intoCesiumGS:mainfrom
Open
Conversation
Contributor
Author
|
I'm not deeply familiar with cesium-native internals yet so I'm happy to receive feedback on better ways to implement this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tileset::sampleHeightMostDetailed()run asynchronously and causes the tileset to fully load the most detailed level before resolving a result. In some cases it's more useful to know what the height of the currently-loaded LOD is, and to know it immediately.Refactored a bit of logic out of TilesetHeightRequest to TilesetHeightQuery in order to reduce code duplication with the new functionality.
Issue number or link
Fixes #1216.
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Testing plan
Added unit tests to cover additive-refined, replace-refined, and partially-loaded tilesets as well as exercising the convenience overload.
Reviewer checklist
Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.
As you review, please go through the checklist below:
CHANGES.mdto make sure they accurately cover the work in this PR.