Skip to content

Commit fdd773e

Browse files
committed
Merge branch 'main' into const-get-root-tile
2 parents 1ff3298 + a87e489 commit fdd773e

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ jobs:
4949
# and using them ensures we're compiling our plugin in the exact same way that Unreal Engine itself is compiled.
5050
cmake-generator: "Visual Studio 17 2022"
5151
cmake-toolchain: "version=14.34"
52-
cmake-platform: "x64,version=10.0.18362.0"
52+
cmake-platform: "x64,version=10.0.19041.0"
5353
visual-studio-version: "2022"
54-
visual-studio-components: "Microsoft.VisualStudio.Component.VC.14.34.17.4.x86.x64,Microsoft.VisualStudio.Component.Windows10SDK.18362"
54+
visual-studio-components: "Microsoft.VisualStudio.Component.VC.14.34.17.4.x86.x64,Microsoft.VisualStudio.Component.Windows10SDK.19041"
5555
TestWindows54:
5656
needs: [Windows54]
5757
uses: ./.github/workflows/testWindows.yml

CHANGES.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Change Log {#changes}
22

3+
### ???
4+
5+
##### Fixes :wrench:
6+
7+
- Added a missing `CesiumRuntime.h` include in `CesiumPropertyAttribute.cpp` that broke compilation in v2.18.0 on Windows.
8+
39
### v2.18.0 - 2025-08-01
410

511
##### Breaking Changes :mega:

Source/CesiumRuntime/Private/CesiumPropertyAttribute.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// Copyright 2020-2024 CesiumGS, Inc. and Contributors
22

33
#include "CesiumPropertyAttribute.h"
4+
#include "CesiumRuntime.h"
45
#include <CesiumGltf/PropertyAttributeView.h>
56

67
static FCesiumPropertyAttributeProperty EmptyPropertyAttributeProperty;

extern/CMakeLists.txt

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,17 @@ if (DEFINED ENV{UNREAL_ENGINE_ROOT} AND NOT UNREAL_ENGINE_ROOT)
1111
endif()
1212

1313
if (NOT UNREAL_ENGINE_ROOT)
14-
# On Windows, try to use the default UE 5.4 location
15-
set(WINDOWS_DEFAULT_UNREAL_INSTALLATION "C:/Program Files/Epic Games/UE_5.4")
16-
if (WIN32 AND EXISTS "${WINDOWS_DEFAULT_UNREAL_INSTALLATION}")
17-
set(UNREAL_ENGINE_ROOT "${WINDOWS_DEFAULT_UNREAL_INSTALLATION}")
14+
# On Windows and Mac, try to use the default UE 5.4 location
15+
if (WIN32)
16+
set(DEFAULT_UNREAL_INSTALLATION "C:/Program Files/Epic Games/UE_5.4")
17+
elseif(APPLE)
18+
set(DEFAULT_UNREAL_INSTALLATION "/Users/Shared/Epic Games/UE_5.4")
19+
endif()
20+
21+
if (NOT EXISTS "${DEFAULT_UNREAL_INSTALLATION}")
22+
message(FATAL_ERROR "Please specify the root of your Unreal Engine installation, either by setting the UNREAL_ENGINE_ROOT environment variable or with -DUNREAL_ENGINE_ROOT=path on the cmake command-line.")
1823
else()
19-
message(FATAL_ERROR "Please specify the root of your Unreal Engine installation, either by setting the UNREAL_ENGINE_ROOT environment variable or with -DUNREAL_ENGINE_ROOT=path on the cmake command-line.")
24+
set(UNREAL_ENGINE_ROOT "${DEFAULT_UNREAL_INSTALLATION}")
2025
endif()
2126
endif()
2227

0 commit comments

Comments
 (0)