Fixes for Unreal 5.7 #1755
Open
Fixes for Unreal 5.7 #1755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kring
reviewed
Nov 13, 2025
|
|
||
| #define ENGINE_VERSION_5_5_OR_HIGHER \ | ||
| (ENGINE_MAJOR_VERSION > 5 || ENGINE_MINOR_VERSION >= 5) | ||
| (ENGINE_MAJOR_VERSION > 5 && ENGINE_MINOR_VERSION >= 5) |
Member
There was a problem hiding this comment.
|| was correct, && is wrong. Think about how it will evaluate for 5.4, 5.5, and 6.1.
Contributor
Author
There was a problem hiding this comment.
I guess this should be >= 5 or > 4, but wouldn't ENGINE_MAJOR_VERSION > 5 || ENGINE_MINOR_VERSION >= 5 also trigger for, say, Unreal 4.27?
Contributor
Author
There was a problem hiding this comment.
Ah, I see. It should be (ENGINE_MAJOR_VERSION == 5 && ENGINE_MINOR_VERSION >= 5) || (ENGINE_MAJOR_VERSION > 5)
Member
There was a problem hiding this comment.
Yeah, the original formulation of this won't work at all in 4.27. But neither will anything else in this code base. 😁
I'm pretty sure this will work in UE 5.6 and 5.7, but maybe not in earlier versions.
So we use the one from cesium-native instead.
The release notes say r25b is the minimum, but it doesn't work, and the Editor UI reports r27c is the actual minimum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Unreal 5.7 preview is here, so I went through and updated everything to work with the new version. Most of the changes involve texture loading, as some of the deprecated paths we were using are now fully removed.
Still need to get 5.7 working on CI. Will probably wait for full release for that one.