Data Augmentation : SMILES #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aditya0by0
commented
Jul 30, 2025
aditya0by0
commented
- closes SMILES augmentation #113
Member
Author
|
@sfluegel05, Please review and merge the PR. |
sfluegel05
reviewed
Sep 25, 2025
| self._chebi_version_train_obj.setup() | ||
|
|
||
| def _load_dict(self, input_file_path: str) -> Generator[Dict[str, Any], None, None]: | ||
| def _load_dict(self, input_file_path: str) -> Generator[dict[str, Any], None, None]: |
Collaborator
There was a problem hiding this comment.
is there a reason or this change? The only difference I see is that we lose support for python<3.9 with dict
Member
Author
There was a problem hiding this comment.
Since we’ve already set Python 3.10 as the minimum requirement in #105
, there’s no need to import type hints from typing or typing_extensions. Using built-in type hints (e.g., dict[...]) is both explicit and consistent with Python 3.10+ features, which is why this change was made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.