fix order of operations during none filtering in data preprocessing #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya0by0
approved these changes
May 7, 2025
Member
aditya0by0
left a comment
aditya0by0
left a comment
There was a problem hiding this comment.
@sfluegel05, Yes it works now. Please merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves ChEB-AI/python-chebai-graph#5
Due to missing brackets, it was checked if
val["features"]is None or if it has a certain length. It should be: only ifval["features"]is not None, check for the length.@aditya0by0 can you check if that resolves your issue?
Also: For graph neural network, we should probably count the number of nodes towards the
n_token_limit