Skip to content

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 10, 2025

Summary of changes

Changes introduced in this pull request:

  • added units to balances,
  • limit balances to two decimal digits (we don't care about smaller units and copying humantoken from Forest would be an overkill)

image

Reference issue to close (if applicable)

Closes #70

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 10, 2025 13:36
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 59.25926% with 11 lines in your changes missing coverage. Please review.

Project coverage is 11.04%. Comparing base (5975f2b) to head (fc4b8f7).

Files with missing lines Patch % Lines
src/faucet/controller.rs 0.00% 7 Missing ⚠️
src/faucet/views.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##            main     #109      +/-   ##
=========================================
+ Coverage   9.88%   11.04%   +1.15%     
=========================================
  Files         25       25              
  Lines       1163     1186      +23     
=========================================
+ Hits         115      131      +16     
- Misses      1048     1055       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LesnyRumcajs LesnyRumcajs marked this pull request as draft January 10, 2025 13:41
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review January 10, 2025 16:07
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit c5250dd Jan 13, 2025
5 checks passed
@LesnyRumcajs LesnyRumcajs deleted the add-unit-to-balances branch January 13, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add units to balances

4 participants