Skip to content

Add fallback for tx hash resolution by cid in claim token API #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sudo-shashank wants to merge 4 commits into from
Closed

Add fallback for tx hash resolution by cid in claim token API #326

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
befe40c
add fallback for eth get tx hash
sudo-shashank Oct 13, 2025
d93caad
Add log
sudo-shashank Oct 13, 2025
7c29166
fmt
sudo-shashank Oct 13, 2025
359b26c
Merge branch 'main' into shashank/fix-claim-token-api
sudo-shashank Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/api-documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ transaction hash confirming the token transfer.

- Each address is subject to rate limiting to prevent abuse.
- This API only distributes Calibnet `tFIL` and `tUSDFC` tokens.
- For native token claims, the API returns the Ethereum transaction hash if
resolvable via `Filecoin.EthGetTransactionHashByCid`; otherwise, it returns
the CID.

---

Expand Down
6 changes: 3 additions & 3 deletions src/faucet/server_api.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,11 +289,11 @@ async fn handle_native_claim(
{
Ok(LotusJson(smsg)) => {
let cid = rpc.mpool_push(smsg).await.map_err(ServerFnError::new)?;
let tx_hash = rpc
Ok(rpc
.eth_get_transaction_hash_by_cid(cid)
.await
.map_err(ServerFnError::new)?;
Ok(tx_hash.to_string())
.map(|tx_hash| tx_hash.to_string())
.unwrap_or_else(|_| cid.to_string()))
}
Err(err) => Err(handle_faucet_error(err)),
}
Expand Down
Loading