Skip to content

Conversation

@sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Nov 3, 2025

Summary of changes

Changes introduced in this pull request:

  • Increase MAX_MAINNET_GAS_FEE_CAP to ensure messages are included in blocks.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Increased the maximum mainnet gas fee cap for the faucet from 1,000,000 atto to 100,000,000 atto.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 3, 2025

Walkthrough

The pull request increases the maximum mainnet gas fee cap in the faucet constants from 1,000,000 atto to 100,000,000 atto, and updates the corresponding test assertion to verify the new cap value.

Changes

Cohort / File(s) Summary
Faucet gas fee cap increase
src/faucet/constants.rs
Updated mainnet maximum gas fee cap constant from 1,000,000 to 100,000,000 atto; adjusted test assertion to match new cap value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • akaladarshi
  • hanabi1224

Poem

🐰 A cap so high, one hundred million strong,
Atto by atto, fees flow along,
The faucet flows freely, the constants align,
Testing ensures all the numbers are fine!

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'Fix mainnet low gas fee cap' directly relates to the main change in the changeset, which increases the maximum mainnet gas fee cap from 1,000,000 atto to 100,000,000 atto to resolve an issue with messages not being included in blocks. The title is concise, clear, and accurately summarizes the primary change from the developer's perspective.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shashank/fix-max-gas-fee-cap-mainnet

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 020536f and 655af13.

📒 Files selected for processing (1)
  • src/faucet/constants.rs (2 hunks)
🔇 Additional comments (2)
src/faucet/constants.rs (2)

231-234: LGTM! Test correctly updated to reflect the new constant value.

The test assertion properly validates the new MAX_MAINNET_GAS_FEE_CAP value of 100,000,000 atto, maintaining test accuracy and coverage.


38-40: Verify the new gas fee cap aligns with current mainnet conditions.

The 100x increase from 1,000,000 to 100,000,000 atto significantly raises the maximum gas cost from 0.00001 FIL to 0.001 FIL (10% of the drip amount). While the PR states this is needed to ensure message inclusion, please verify this value is appropriate for current Filecoin mainnet gas prices.

Run the following script to check recent mainnet gas prices and compare with the new cap:

Additionally, consider querying current Filecoin mainnet gas prices from a public API or block explorer to confirm that 100,000,000 atto (0.0000001 FIL per gas unit) is sufficient for transaction inclusion.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.75%. Comparing base (020536f) to head (655af13).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   38.75%   38.75%           
=======================================
  Files          40       40           
  Lines        2578     2578           
=======================================
  Hits          999      999           
  Misses       1579     1579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sudo-shashank sudo-shashank marked this pull request as ready for review November 3, 2025 12:41
@sudo-shashank sudo-shashank requested a review from a team as a code owner November 3, 2025 12:41
@sudo-shashank sudo-shashank added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit 9615c1b Nov 3, 2025
7 checks passed
@sudo-shashank sudo-shashank deleted the shashank/fix-max-gas-fee-cap-mainnet branch November 3, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants