-
Notifications
You must be signed in to change notification settings - Fork 2
Fix mainnet low gas fee cap #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request increases the maximum mainnet gas fee cap in the faucet constants from 1,000,000 atto to 100,000,000 atto, and updates the corresponding test assertion to verify the new cap value. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 38.75% 38.75%
=======================================
Files 40 40
Lines 2578 2578
=======================================
Hits 999 999
Misses 1579 1579 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary of changes
Changes introduced in this pull request:
MAX_MAINNET_GAS_FEE_CAPto ensure messages are included in blocks.Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
adheres to the team's
documentation standards,
(if possible),
should be reflected in this document.
Summary by CodeRabbit