-
Notifications
You must be signed in to change notification settings - Fork 2
chore: increase gas limit for calibnet transactions #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA single constant Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
🔇 Additional comments (3)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/faucet/constants.rs (2)
274-274: Update test assertion to reflect the new gas limit.This test assertion still checks for the old gas limit value (30_000_000) but the constant has been updated to 100_000_000. This will cause the test to fail.
Apply this diff to fix the test:
- assert_eq!(calibnet_fil_faucet.max_gas_limit(), 30_000_000); + assert_eq!(calibnet_fil_faucet.max_gas_limit(), 100_000_000);
313-313: Update test assertion to reflect the new gas limit.This test assertion still checks for the old gas limit value (30_000_000) but the constant has been updated to 100_000_000. This will cause the test to fail.
Apply this diff to fix the test:
- assert_eq!(calibnet_usdfc_faucet.max_gas_limit(), 30_000_000); + assert_eq!(calibnet_usdfc_faucet.max_gas_limit(), 100_000_000);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/faucet/constants.rs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: codedov
- GitHub Check: lint
- GitHub Check: E2E API Tests
- GitHub Check: E2E Browser Tests
- GitHub Check: deploy
- GitHub Check: E2E Claim Token API CORS Tests
298d993 to
2c036d3
Compare
2c036d3 to
a6f53e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 41.09% 41.11% +0.02%
==========================================
Files 40 40
Lines 2667 2668 +1
==========================================
+ Hits 1096 1097 +1
Misses 1571 1571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary of changes
Some top ups are failing due to 33 - out of gas limit; let's bump it. Sample transaction: https://beryx.io/fil/calibration/txs/bafy2bzaceauhhdtojpyfmpkd7j2nzrbm6dibnmglhfhfdqk6ek5m5ak47ejwa
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
adheres to the team's
documentation standards,
(if possible),
should be reflected in this document.
Summary by CodeRabbit