Skip to content

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Nov 15, 2025

Summary of changes

Some top ups are failing due to 33 - out of gas limit; let's bump it. Sample transaction: https://beryx.io/fil/calibration/txs/bafy2bzaceauhhdtojpyfmpkd7j2nzrbm6dibnmglhfhfdqk6ek5m5ak47ejwa

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

Summary by CodeRabbit

  • Bug Fixes
    • The maximum gas limit for calibnet faucets has been increased from 30,000,000 to 100,000,000, allowing larger transactions to be processed and reducing failures for operations that previously exceeded the threshold. This improves reliability for high-gas transactions on calibnet. No other user-facing behavior or error handling has changed.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner November 15, 2025 17:02
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 15, 2025

Walkthrough

A single constant MAX_CALIBNET_GAS_LIMIT in the faucet module is changed from 30_000_000 to 100_000_000. No code paths, logic, or error handling were modified.

Changes

Cohort / File(s) Change Summary
Faucet Constants
src/faucet/constants.rs
Updated MAX_CALIBNET_GAS_LIMIT constant value: 30_000_000 -> 100_000_000

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Quick check: ensure no tests or docs rely on the previous numeric value beyond those already updated.

Possibly related PRs

Suggested reviewers

  • hanabi1224
  • sudo-shashank
  • elmattic

Poem

🐰 A constant hops up, from thirty to a hundred bright,
Calibnet whispers softly in the night,
No tangled logic, no panic or fright,
Just a gentle bump to set things right! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: increasing the gas limit for calibnet transactions from 30M to 100M, which aligns with the PR objectives of addressing failing top-ups.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch increase-gas-limit-calibnet

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 298d993 and a6f53e4.

📒 Files selected for processing (1)
  • src/faucet/constants.rs (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: E2E API Tests
  • GitHub Check: E2E Browser Tests
  • GitHub Check: E2E Claim Token API CORS Tests
  • GitHub Check: lint
  • GitHub Check: codedov
  • GitHub Check: deploy
🔇 Additional comments (3)
src/faucet/constants.rs (3)

52-52: LGTM! Gas limit increase is justified and well-documented.

The 3.3x increase to 100M addresses the documented "out of gas limit" errors on calibnet. Since this is a testnet environment, the higher limit is acceptable.


274-274: Excellent refactor to use the constant.

Referencing MAX_CALIBNET_GAS_LIMIT instead of a hardcoded value ensures the test stays synchronized with the actual constant and improves maintainability.


313-316: Consistent test update matches the pattern established for CalibnetFIL.

The CalibnetUSDFC test now properly references the shared constant, maintaining consistency across both calibnet faucet tests.


Comment @coderabbitai help to get the list of available commands and usage tips.

sudo-shashank
sudo-shashank previously approved these changes Nov 15, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
src/faucet/constants.rs (2)

274-274: Update test assertion to reflect the new gas limit.

This test assertion still checks for the old gas limit value (30_000_000) but the constant has been updated to 100_000_000. This will cause the test to fail.

Apply this diff to fix the test:

-        assert_eq!(calibnet_fil_faucet.max_gas_limit(), 30_000_000);
+        assert_eq!(calibnet_fil_faucet.max_gas_limit(), 100_000_000);

313-313: Update test assertion to reflect the new gas limit.

This test assertion still checks for the old gas limit value (30_000_000) but the constant has been updated to 100_000_000. This will cause the test to fail.

Apply this diff to fix the test:

-        assert_eq!(calibnet_usdfc_faucet.max_gas_limit(), 30_000_000);
+        assert_eq!(calibnet_usdfc_faucet.max_gas_limit(), 100_000_000);
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5031025 and 298d993.

📒 Files selected for processing (1)
  • src/faucet/constants.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: codedov
  • GitHub Check: lint
  • GitHub Check: E2E API Tests
  • GitHub Check: E2E Browser Tests
  • GitHub Check: deploy
  • GitHub Check: E2E Claim Token API CORS Tests

@LesnyRumcajs LesnyRumcajs force-pushed the increase-gas-limit-calibnet branch from 2c036d3 to a6f53e4 Compare November 15, 2025 17:07
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.11%. Comparing base (5031025) to head (a6f53e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   41.09%   41.11%   +0.02%     
==========================================
  Files          40       40              
  Lines        2667     2668       +1     
==========================================
+ Hits         1096     1097       +1     
  Misses       1571     1571              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Nov 15, 2025
Merged via the queue into main with commit 301db0a Nov 15, 2025
7 checks passed
@LesnyRumcajs LesnyRumcajs deleted the increase-gas-limit-calibnet branch November 15, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants