-
Notifications
You must be signed in to change notification settings - Fork 2
chore: bump rust toolchain to 1.92.0 #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates the Rust toolchain version from 1.91.0 to 1.92.0 and optimizes development build profiles by limiting debug information for dev builds and disabling debug info for all dependencies. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Cargo.toml (1)
80-87: Good size win; be explicit about the debugging tradeoff (deps will have no symbols).
[profile.dev] debug = "line-tables-only"plus disabling debug info for dependencies is a solid default for faster/smaller dev builds, but it will make stepping into deps / symbolicated backtraces in deps much worse. Consider adding a short README note or an opt-in “full debug” profile/workflow for when deeper debugging is needed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Cargo.toml(1 hunks)rust-toolchain.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: E2E API Tests
- GitHub Check: E2E Browser Tests
- GitHub Check: E2E Claim Token API CORS Tests
- GitHub Check: codedov
- GitHub Check: lint
- GitHub Check: deploy
🔇 Additional comments (1)
Cargo.toml (1)
80-87: No action needed. This repository is not a Cargo workspace (no[workspace]section exists), so the profile settings in the rootCargo.tomlare correctly placed and will apply to the entire project as intended.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
=======================================
Coverage 41.11% 41.11%
=======================================
Files 40 40
Lines 2668 2668
=======================================
Hits 1097 1097
Misses 1571 1571 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary of changes
Changes introduced in this pull request:
main:
pr:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
adheres to the team's
documentation standards,
(if possible),
should be reflected in this document.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.