Skip to content

fix: speed up void db migration#5452

Merged
hanabi1224 merged 4 commits intomainfrom
hm/speed-up-void-migration
Mar 25, 2025
Merged

fix: speed up void db migration#5452
hanabi1224 merged 4 commits intomainfrom
hm/speed-up-void-migration

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Mar 24, 2025

Summary of changes

Changes introduced in this pull request:

  • hard link files recursively instead of copying in void db migration to speed up the process and reduce additional disk usage

Reference issue to close (if applicable)

Closes #5451

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review March 24, 2025 12:05
@hanabi1224 hanabi1224 requested a review from a team as a code owner March 24, 2025 12:05
@hanabi1224 hanabi1224 requested review from LesnyRumcajs, elmattic and lemmih and removed request for a team March 24, 2025 12:05
@hanabi1224 hanabi1224 force-pushed the hm/speed-up-void-migration branch from 9b24e0d to 75d5d03 Compare March 24, 2025 12:15
@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Mar 24, 2025

If there are no caveats, I'd choose a rename instead of a hardlink. It's just simpler. The implementation will perhaps require more work, but we should strive to make Forest simpler and, in turn, more maintainable. Lingering hard links won't help in that.

@hanabi1224 hanabi1224 force-pushed the hm/speed-up-void-migration branch from ab58a53 to 8aef5e7 Compare March 24, 2025 15:55
@hanabi1224 hanabi1224 force-pushed the hm/speed-up-void-migration branch from 8aef5e7 to b8b3e6d Compare March 24, 2025 16:09
@hanabi1224
Copy link
Contributor Author

If there are no caveats, I'd choose a rename instead of a hardlink. It's just simpler. The implementation will perhaps require more work, but we should strive to make Forest simpler and, in turn, more maintainable. Lingering hard links won't help in that.

@LesnyRumcajs Done

@hanabi1224 hanabi1224 changed the title fix: speed up void db migration by hard linking files instead of copying fix: speed up void db migration Mar 25, 2025
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding to the changelog, given it massively speeds up db migrations on some systems.

@hanabi1224 hanabi1224 added this pull request to the merge queue Mar 25, 2025
@hanabi1224
Copy link
Contributor Author

Might be worth adding to the changelog, given it massively speeds up db migrations on some systems.

@LesnyRumcajs changelog updated, please re-approve.

@hanabi1224 hanabi1224 removed this pull request from the merge queue due to a manual request Mar 25, 2025
@hanabi1224 hanabi1224 enabled auto-merge March 25, 2025 15:41
@hanabi1224 hanabi1224 added this pull request to the merge queue Mar 25, 2025
Merged via the queue into main with commit b6b484d Mar 25, 2025
41 checks passed
@hanabi1224 hanabi1224 deleted the hm/speed-up-void-migration branch March 25, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Void database migration should be fast and require no additional disk space

3 participants