Skip to content

Fix stack overflow in debug mode#5458

Merged
lemmih merged 2 commits intomainfrom
elmattic/fix-stack-ovf-in-dev-mode
Mar 26, 2025
Merged

Fix stack overflow in debug mode#5458
lemmih merged 2 commits intomainfrom
elmattic/fix-stack-ovf-in-dev-mode

Conversation

@elmattic
Copy link
Contributor

@elmattic elmattic commented Mar 25, 2025

Summary of changes

Changes introduced in this pull request:

  • Fix stack overflow occurring when running Forest in debug mode

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic marked this pull request as ready for review March 25, 2025 16:13
@elmattic elmattic requested a review from a team as a code owner March 25, 2025 16:13
@elmattic elmattic requested review from hanabi1224 and lemmih and removed request for a team March 25, 2025 16:13
@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Mar 25, 2025

What's precisely causing the SO?

Ah okay, we recursively call the mark_bad_tipset

Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for the seal of approval from @lemmih before merging.

@lemmih
Copy link
Contributor

lemmih commented Mar 26, 2025

Sigh, my love of recursion comes to haunt me.

@lemmih lemmih added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit 4341111 Mar 26, 2025
46 checks passed
@lemmih lemmih deleted the elmattic/fix-stack-ovf-in-dev-mode branch March 26, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants