Add support for the Filecoin.EthSendRawTransactionUntrusted#6524
Add support for the Filecoin.EthSendRawTransactionUntrusted#6524sudo-shashank merged 16 commits intomainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds an untrusted message path: new Filecoin.EthSendRawTransactionUntrusted RPC (v2) that routes to mpool.push_untrusted, threads an Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant RPC as RPC v2 (eth)
participant MPool as MPool
participant MsgPool as MessagePool
participant MsgSet as MsgSet
Client->>RPC: EthSendRawTransactionUntrusted(rawTx)
RPC->>MPool: build SignedMessage, call mpool.push_untrusted(smsg)
MPool->>MsgPool: push_untrusted(smsg)
MsgPool->>MsgPool: push_internal(smsg, untrusted=true)
MsgPool->>MsgSet: add_tipset/add_helper(..., untrusted=true)
MsgSet->>MsgSet: add_untrusted validation & publish path
MsgSet-->>MsgPool: return Cid/result
MsgPool-->>MPool: propagate result
MPool-->>RPC: return Cid / EthHash
RPC-->>Client: RPC response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
sudo-shashank
requested review from
LesnyRumcajs and
hanabi1224
and removed request for
a team
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Line 52: Replace the PR link entry in CHANGELOG.md that currently reads
"[`#6524`](https://github.com/ChainSafe/forest/pull/6524): Implemented
`Filecoin.EthSendRawTransactionUntrusted` for API v2." with an issue-based entry
referencing issue `#6305` using the changelog convention:
"[`#6305`](https://github.com/ChainSafe/forest/issues/6305): Implemented
`Filecoin.EthSendRawTransactionUntrusted` for API v2." — i.e., swap the
pull-request URL/number for the issue URL/number and keep the same description.
🧹 Nitpick comments (1)
src/message_pool/msgpool/msg_pool.rs (1)
218-246: LGTM with minor nit.The refactoring to introduce
push_internalwith anuntrustedflag and exposepushandpush_untrustedas public wrappers is clean and correctly routes messages through the appropriate trust paths.Minor grammar nit on line 238: "an trusted" should be "a trusted".
,
📝 Suggested fix for the doc comment
- /// Push a signed message to the `MessagePool` from an trusted source. + /// Push a signed message to the `MessagePool` from a trusted source.
Codecov Report❌ Patch coverage is Additional details and impacted files
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
hanabi1224
left a comment
hanabi1224
left a comment
There was a problem hiding this comment.
Please move the changelog entry to the new unreleased section
2 participants
Summary of changes
Changes introduced in this pull request:
Filecoin.EthSendRawTransactionUntrustedV1 & V2.Filecoin.MpoolPushUntrusted: Use mpoolpush_untrustedinstead ofpushmethod.Reference issue to close (if applicable)
Closes #6305
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
New Features
Chores