Skip to content

fix(test): add --api-wait-lookback-limit 2000 to lotus-gateway#6589

Merged
hanabi1224 merged 4 commits intomainfrom
hm/fix-api-compare-gateway-setup
Feb 11, 2026
Merged

fix(test): add --api-wait-lookback-limit 2000 to lotus-gateway#6589
hanabi1224 merged 4 commits intomainfrom
hm/fix-api-compare-gateway-setup

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Feb 11, 2026

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #6581
Closes #6582
Closes #6583
Closes #6584
Closes #6578
Closes #6579
Closes #6577

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Fixed EthGetBalance compatibility issue with Lotus Gateway
  • Improvements

    • Enhanced RPC method support: EthGetBlockReceipts, EthGetTransactionByHash, EthGetTransactionReceipt, StateSearchMsg, and StateWaitMsg are now fully functional

@hanabi1224 hanabi1224 added the RPC requires calibnet RPC checks to run on CI label Feb 11, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 11, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • src/rpc/snapshots/forest__rpc__tests__rpc__v0.snap is excluded by !**/*.snap
  • src/rpc/snapshots/forest__rpc__tests__rpc__v1.snap is excluded by !**/*.snap
  • src/rpc/snapshots/forest__rpc__tests__rpc__v2.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR fixes multiple Filecoin RPC method compatibility issues with Lotus Gateway by updating test configurations, filter lists, and RPC handling. Methods previously marked as broken are now validated as fixed, and test infrastructure is updated to support proper validation.

Changes

Cohort / File(s) Summary
Gateway Test Configuration
scripts/tests/api_compare/docker-compose.yml, scripts/tests/api_compare/filter-list-gateway
Updated docker-compose service with --api-wait-lookback-limit 2000 flag; moved 7 RPC methods from "broken" to fixed status; added EthGetBlockReceiptsLimited to "not supported" list.
RPC Method Enhancements
src/rpc/methods/eth.rs, src/rpc/log_layer.rs
Added serde(default) attribute to BlockHash struct's require_canonical field; refactored log_layer.rs to use centralized log_enabled() helper instead of duplicated tracing::enabled! checks.
Documentation
CHANGELOG.md
Added Fixed entry documenting Filecoin.EthGetBalance compatibility issue resolution (issue #6577).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • sudo-shashank
🚥 Pre-merge checks | ✅ 1 | ❌ 4
❌ Failed checks (3 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title focuses on the test infrastructure change (adding a flag to docker-compose), but the changeset includes broader code fixes affecting RPC methods beyond just the test setup. Revise title to reflect the full scope, such as 'fix(rpc): fix Filecoin RPC methods compatibility with lotus-gateway' to accurately represent all fixes included.
Out of Scope Changes check ⚠️ Warning Changes to src/rpc/log_layer.rs (tracing refactor) and src/rpc/methods/eth.rs (serde attribute) appear tangentially related to RPC fixes but lack clear connection to lotus-gateway compatibility. Clarify the necessity of log_layer.rs and eth.rs changes for lotus-gateway compatibility; consider separating unrelated refactoring into a distinct PR if not essential.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check ❓ Inconclusive The PR removes 6 methods from the 'broken' filter list, directly addressing issues #6581-6584, #6578, #6579, #6577, though full functional fixes are unclear from code changes alone. Verify that code changes in eth.rs and log_layer.rs substantively fix the broken RPC methods; provide additional documentation linking specific code changes to each resolved issue.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/fix-api-compare-gateway-setup

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review February 11, 2026 11:11
@hanabi1224 hanabi1224 requested a review from a team as a code owner February 11, 2026 11:11
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and removed request for a team February 11, 2026 11:11
LesnyRumcajs
LesnyRumcajs previously approved these changes Feb 11, 2026
@hanabi1224 hanabi1224 enabled auto-merge February 11, 2026 11:24
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.36%. Comparing base (1ca70e0) to head (4784f8c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/rpc/log_layer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/rpc/methods/eth.rs 69.66% <ø> (ø)
src/rpc/log_layer.rs 48.88% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ca70e0...4784f8c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 11, 2026
Merged via the queue into main with commit 796f531 Feb 11, 2026
44 of 45 checks passed
@hanabi1224 hanabi1224 deleted the hm/fix-api-compare-gateway-setup branch February 11, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

2 participants