Skip to content

chore(deps): favor re-exported digest crate#6603

Merged
LesnyRumcajs merged 1 commit intomainfrom
hm/no-digest
Feb 13, 2026
Merged

chore(deps): favor re-exported digest crate#6603
LesnyRumcajs merged 1 commit intomainfrom
hm/no-digest

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Feb 13, 2026

Summary of changes

This PR removes digest from Cargo.toml to avoid managing its version. (Upgrading to the latest 0.11 causes build errors)

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Removed unused digest dependency to streamline the dependency tree
    • Updated development dependency versions for tooling improvements
    • Reorganized internal imports across modules to consolidate cryptographic dependency usage

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 13, 2026

Walkthrough

This PR removes the digest crate dependency from the project and replaces all references to its Digest trait with imports from the sha2 crate's digest module. It also bumps the ra_ap_syntax dev-dependency to version 0.0.319.

Changes

Cohort / File(s) Summary
Dependency Updates
Cargo.toml
Removed digest = "0.10" dependency; bumped ra_ap_syntax dev-dependency from "0.0.318" to "0.0.319".
Digest Trait Import Migration
src/beacon/beacon_entries.rs, src/chain/mod.rs, src/state_manager/utils.rs, src/utils/io/writer_checksum.rs
Updated imports to source Digest trait from sha2::digest instead of the digest crate, with no changes to control flow or public APIs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

dependencies, rust

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(deps): favor re-exported digest crate' accurately describes the main change: removing the direct digest dependency and using the re-exported version from sha2 instead.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/no-digest

No actionable comments were generated in the recent review. 🎉


Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review February 13, 2026 11:13
@hanabi1224 hanabi1224 requested a review from a team as a code owner February 13, 2026 11:13
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team February 13, 2026 11:13
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.36%. Comparing base (e7ad657) to head (99a536a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/beacon/beacon_entries.rs 100.00% <ø> (ø)
src/chain/mod.rs 74.75% <ø> (ø)
src/state_manager/utils.rs 79.56% <ø> (-0.25%) ⬇️
src/utils/io/writer_checksum.rs 82.88% <ø> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ad657...99a536a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit 58ba383 Feb 13, 2026
39 checks passed
@LesnyRumcajs LesnyRumcajs deleted the hm/no-digest branch February 13, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants