Skip to content

Disable flaky checks in wallet test#6734

Merged
sudo-shashank merged 1 commit intomainfrom
shashank/disable-new-wallet-checks
Mar 13, 2026
Merged

Disable flaky checks in wallet test#6734
sudo-shashank merged 1 commit intomainfrom
shashank/disable-new-wallet-checks

Conversation

@sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Mar 13, 2026

Summary of changes

Changes introduced in this pull request:

  • Disabling some wallet checks until nonce calculation is fixed.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

Chores

  • Disabled wallet validation testing procedures in the CI/CD pipeline.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d94203a5-3fa8-4d6e-8300-0b92d51dcb74

📥 Commits

Reviewing files that changed from the base of the PR and between 8149f08 and 0c9fdb6.

📒 Files selected for processing (2)
  • .github/workflows/forest.yml
  • scripts/tests/calibnet_wallet_check.sh

Walkthrough

This pull request disables the calibnet-delegated-wallet-check CI job in the workflow by adding a conditional guard, and comments out corresponding wallet check operations and RPC instrumentation in the test script, while preserving the surrounding control flow and wallet creation/deletion tests.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/forest.yml
Added explanatory comment and if: false conditional to disable the calibnet-delegated-wallet-check job without removing it.
Wallet Check Test Script
scripts/tests/calibnet_wallet_check.sh
Commented out external RPC calls (Filecoin-to-Eth address conversion), fund transfers, balance polling loops (ADDR_TWO_BALANCE, ADDR_THREE_BALANCE), and remote wallet balance checks while retaining wallet creation and deletion tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • hanabi1224
  • LesnyRumcajs
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Disable flaky checks in wallet test' directly aligns with the changeset, which disables wallet-related checks in both the workflow and test script due to flakiness.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shashank/disable-new-wallet-checks
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch shashank/disable-new-wallet-checks
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank marked this pull request as ready for review March 13, 2026 09:19
@sudo-shashank sudo-shashank requested a review from a team as a code owner March 13, 2026 09:19
@sudo-shashank sudo-shashank requested review from LesnyRumcajs and hanabi1224 and removed request for a team March 13, 2026 09:19
@sudo-shashank sudo-shashank enabled auto-merge March 13, 2026 09:19
Copy link
Contributor

@hanabi1224 hanabi1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to have an issue to track re-enabling them.

@sudo-shashank sudo-shashank added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit bb374bb Mar 13, 2026
42 checks passed
@sudo-shashank sudo-shashank deleted the shashank/disable-new-wallet-checks branch March 13, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants