-
Notifications
You must be signed in to change notification settings - Fork 4
feat: enhance clone api #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @twoeths, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a powerful enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant enhancement to the clone API for SSZ types (Container, List, Vector), allowing cloning into a superset type. This is a well-executed improvement that greatly simplifies the state upgrade logic, as demonstrated by the refactoring in upgrade_state_to_capella.zig and upgrade_state_to_deneb.zig. The use of anytype and compile-time checks is idiomatic and effective. The accompanying tests are thorough and validate the new functionality well. My review comments focus on further improving safety by adding comptime assertions to the new clone functions, in accordance with the repository's style guide, which emphasizes the rigorous use of assertions.
| capella_latest_execution_payload_header.base_fee_per_gas = bellatrix_latest_execution_payload_header.base_fee_per_gas; | ||
| capella_latest_execution_payload_header.block_hash = bellatrix_latest_execution_payload_header.block_hash; | ||
| capella_latest_execution_payload_header.transactions_root = bellatrix_latest_execution_payload_header.transactions_root; | ||
| try ssz.bellatrix.ExecutionPayloadHeader.clone(allocator, &bellatrix_latest_execution_payload_header, &capella_latest_execution_payload_header); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied the new clone() api here and the below upgrade_state_to_deneb.zig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing!
75296fb to
979862a
Compare
spiral-ladder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nits
spiral-ladder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
committed my nitpicks; LGTM
Motivation
ExecutionPayloadHeaderfrom bellatrix -> capella and capella->denebDescription