Skip to content

fix: return reward delta instead of validator balance as sync committee rewards #8774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ensi321 merged 1 commit into from
Jan 22, 2026
Merged

fix: return reward delta instead of validator balance as sync committee rewards #8774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions packages/state-transition/src/rewards/syncCommitteeRewards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ import {BeaconBlock, ValidatorIndex, altair, rewards} from "@lodestar/types";
import {Index2PubkeyCache} from "../cache/pubkeyCache.js";
import {CachedBeaconStateAllForks, CachedBeaconStateAltair} from "../cache/stateCache.js";

type BalanceRecord = {val: number}; // Use val for convenient way to increment/decrement balance

export async function computeSyncCommitteeRewards(
config: BeaconConfig,
index2pubkey: Index2PubkeyCache,
Expand All @@ -29,24 +27,23 @@ export async function computeSyncCommitteeRewards(
const {syncParticipantReward} = preStateAltair.epochCtx;
const {syncCommitteeBits} = altairBlock.body.syncAggregate;

// Use balance of each committee as starting point such that we cap the penalty to avoid balance dropping below 0
const balances: Map<ValidatorIndex, BalanceRecord> = new Map();
for (const i of syncCommitteeValidatorIndices) {
balances.set(i, {val: preStateAltair.balances.get(i)});
}
// Track reward deltas per validator (can appear multiple times in sync committee)
const rewardDeltas: Map<ValidatorIndex, number> = new Map();

for (const i of syncCommitteeValidatorIndices) {
const balanceRecord = balances.get(i) as BalanceRecord;
// Iterate by position index to correctly access syncCommitteeBits
for (let i = 0; i < syncCommitteeValidatorIndices.length; i++) {
const validatorIndex = syncCommitteeValidatorIndices[i];
const currentDelta = rewardDeltas.get(validatorIndex) ?? 0;
if (syncCommitteeBits.get(i)) {
// Positive rewards for participants
balanceRecord.val += syncParticipantReward;
rewardDeltas.set(validatorIndex, currentDelta + syncParticipantReward);
} else {
// Negative rewards for non participants
balanceRecord.val = Math.max(0, balanceRecord.val - syncParticipantReward);
rewardDeltas.set(validatorIndex, currentDelta - syncParticipantReward);
}
}

const rewards = Array.from(balances, ([validatorIndex, v]) => ({validatorIndex, reward: v.val}));
const rewards = Array.from(rewardDeltas, ([validatorIndex, reward]) => ({validatorIndex, reward}));

if (validatorIds.length) {
const filtersSet = new Set(validatorIds);
Expand Down
Loading