refactor: clone state in processExecutionPayloadEnvelope#9015
Merged
refactor: clone state in processExecutionPayloadEnvelope#9015
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors processExecutionPayloadEnvelope to clone the beacon state before mutation and return the new state, improving consistency with other state transition functions. A security audit found no vulnerabilities, and the refactor enhances state transition robustness. A minor suggestion was made in a test file to remove a redundant call, but overall, the changes are solid.
Comment on lines
+146
to
+147
| postState.commit(); | ||
| return postState; |
Contributor
There was a problem hiding this comment.
The processExecutionPayloadEnvelope function, which is the operationFn in this case, now internally commits the state before returning it. Therefore, this call to postState.commit() is redundant and can be removed.
Suggested change
| postState.commit(); | |
| return postState; | |
| return postState; |
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
approved these changes
Mar 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #9015 +/- ##
=========================================
Coverage 52.36% 52.36%
=========================================
Files 848 848
Lines 62564 62564
Branches 4609 4609
=========================================
Hits 32761 32761
Misses 29737 29737
Partials 66 66 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processExecutionPayloadEnvelopeto clone the beacon state before mutating it and return the post-state, matching the pattern used bystateTransition()dontTransferCacheoption to control SSZ cache transfer behavior during clonecomputeEnvelopeStateRootand spec test runner to use the returned post-stateTest plan
pnpm buildpassespnpm check-typespasses🤖 Generated with Claude Code