fix: clear attachments when switching chat profiles#2858
Merged
dokterbob merged 2 commits intoChainlit:mainfrom Apr 2, 2026
Merged
fix: clear attachments when switching chat profiles#2858dokterbob merged 2 commits intoChainlit:mainfrom
dokterbob merged 2 commits intoChainlit:mainfrom
Conversation
Chukwuebuka-2003
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
bot
added
size:XS
Contributor
Author
|
image 1: image 2: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
hayescode
approved these changes
Apr 1, 2026
Contributor
hayescode
left a comment
hayescode
left a comment
There was a problem hiding this comment.
Reviewed via Codex
LGTM.
Contributor
Author
@hayescode the workflow needs to be approved |
Clear attachments when confirming a profile switch to prevent confusing behavior where attachments appear but aren't sent (their serverId was tied to the old session). Fixes Chainlit#2853
dokterbob
force-pushed
the
fix/attachment-clear-on-profile-switch
branch
from
ac59afc to
8254ef3
Compare
Contributor
|
@Chukwuebuka-2003 please address the CI then we're good to go! |
Contributor
Author
@hayescode can you approve the CI again? i had to update the branch |
hayescode
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear attachments when confirming a profile switch to prevent confusing behavior where attachments appear but aren't sent (their serverId was tied to the old session).
Fixes #2853
Summary by cubic
Clear attachments when confirming a chat profile switch to avoid showing files from the previous session that wouldn’t send. On confirm, reset
attachmentsStateviarecoiland clear the chat session. Fixes #2853.Written for commit a886879. Summary will update on new commits.