This repository was archived by the owner on Aug 5, 2025. It is now read-only.
feat: prompt variant #142
Merged
feat: prompt variant #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desaxce
reviewed
Nov 11, 2024
|
|
||
|
|
||
| def create_prompt_variant_helper( | ||
| from_lineage_id: Optional[str] = None, |
Contributor
There was a problem hiding this comment.
I take we don't want to expose from_version integer.
desaxce
reviewed
Nov 11, 2024
literalai/version.py
Outdated
| @@ -1 +1 @@ | |||
| __version__ = "0.0.629" | |||
| __version__ = "0.0.630" | |||
Contributor
There was a problem hiding this comment.
Should we try to align with 0.1.0 so we know the switch?
desaxce
reviewed
Nov 11, 2024
literalai/api/dataset_helpers.py
Outdated
| name: str, | ||
| dataset_id: Optional[str] = None, | ||
| prompt_id: Optional[str] = None, | ||
| prompt_experiment_id: Optional[str] = None, |
Contributor
There was a problem hiding this comment.
I'd say we call it prompt_variant_id. We should rename it in the platform code too, else it's going to lead to errors.
desaxce
approved these changes
Nov 12, 2024
desaxce
added a commit
that referenced
this pull request
Nov 12, 2024
* feat: prompt variant * fix: mypy errors on mistralai * fix: rename + version bump --------- Co-authored-by: Hugues de Saxcé <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.