This repository was archived by the owner on Aug 5, 2025. It is now read-only.
chore: bump version #155
Merged
chore: bump version #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementsirieix
commented
Dec 9, 2024
clementsirieix
commented
Dec 9, 2024
clementsirieix
force-pushed
the
clement/bump-version-09-12
branch
from
c345ffc to
2141421
Compare
Matthieu-OD
reviewed
Dec 9, 2024
Contributor
Matthieu-OD
left a comment
Matthieu-OD
left a comment
There was a problem hiding this comment.
Not sure we want to replace dict with lambda: {} they both do the same but the first option is easier to read
|
|
||
| class CustomChatPromptTemplate(ChatPromptTemplate): | ||
| orig_messages: Optional[List[GenerationMessage]] = Field( | ||
| default_factory=list |
Contributor
There was a problem hiding this comment.
they both do the same thing I would keep list though (it seems easier to read)
Contributor
Author
There was a problem hiding this comment.
No they do not as per the linter error:
literalai/observability/generation.py:75: error: Argument "default_factory" to "Field" has incompatible type "type[dict[Any, Any]]"; expected "Union[Callable[[], Never], Callable[[dict[str, Any]], Never]]" [arg-type]
Matthieu-OD
approved these changes
Dec 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes