Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds a new configuration option lazygit.openInEditor that allows users to control whether Lazygit opens in the editor area or remains in the terminal panel. This addresses a user preference where some users may prefer to have Lazygit remain in the dropdown terminal panel rather than being moved to the editor area.
Key changes:
- Added a new boolean configuration setting
lazygit.openInEditorwith a default value oftrueto maintain backward compatibility - Implemented conditional logic to skip moving the terminal to the editor area when the setting is
false - Version bumped to 1.0.7
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/extension.ts | Added configuration check for openInEditor setting; conditionally executes terminal-to-editor movement logic based on user preference |
| package.json | Added lazygit.openInEditor configuration property with boolean type and description |
| package-lock.json | Version bumped from 1.0.6 to 1.0.7 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| export function deactivate() {} | ||
| export function deactivate() { } |
There was a problem hiding this comment.
The spacing inside the curly braces has been changed from the original style. The original code used export function deactivate() {} without spaces, but this change adds a space as export function deactivate() { }. This is inconsistent with the codebase style where empty function bodies use no spaces.
| export function deactivate() { } | |
| export function deactivate() {} |
| "lazygit.openInEditor": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Whether to open Lazygit in the editor or in the terminal" |
There was a problem hiding this comment.
The description could be more clear about what happens when this setting is disabled. Consider updating it to explicitly state that when set to false, Lazygit will remain in the terminal panel instead of being moved to the editor area. For example: "Whether to open Lazygit in the editor area. When false, Lazygit remains in the terminal panel."
| "description": "Whether to open Lazygit in the editor or in the terminal" | |
| "description": "Whether to open Lazygit in the editor area. When false, Lazygit remains in the terminal panel." |
|
ping |
Hey hey,
I just wanted to write that plugin, and then saw yours, does almost what I want, except for begin in the dropdown term.
I added the config :)
Cheers