Skip to content

Conversation

@jacomago
Copy link
Contributor

@jacomago jacomago commented Oct 9, 2024

No description provided.

@jacomago jacomago requested a review from shroffk October 9, 2024 14:42
@github-actions
Copy link

github-actions bot commented Oct 9, 2024

Overall Project 0.67%

There is no coverage information present for the Files changed

@shroffk
Copy link
Collaborator

shroffk commented Oct 21, 2024

Hmm... should we add/keep some references to the old maven stuff.. like a "do you love maven, then you can do this"

@tynanford
Copy link
Contributor

IMO we should keep the README documentation with the normal maven commands unless we decide to implement the maven wrapper for all java maven services (phoebus, alarm tools, cfNameServer, etc)

@jacomago
Copy link
Contributor Author

I updated the README. It was quite out of date...

I tried to make it tied less to a particular release number or OS etc. And to split up Installation/Running and Development more clearly.

@github-actions
Copy link

Overall Project 0.67%

There is no coverage information present for the Files changed

@tynanford
Copy link
Contributor

Thanks, the clean up looks pretty good to me.

I wonder if the maven build command should be included in the "Installation" section since we have pretty infrequently releases. On the other hand, the link to the wiki pages covers this so that is fine.

We have been using elastic search 8.2.x for all the services but I assume 8.11.x is what ESS uses and works well? Is it fair to say 8.2.x -> 8.11.x should all work as far as we know?

@jacomago
Copy link
Contributor Author

The integration tests use 8.11 and have been for a while. So I think that's fine.

@sonarqubecloud
Copy link

@github-actions
Copy link

Overall Project 0.67%

There is no coverage information present for the Files changed

@shroffk shroffk merged commit 8232cd4 into master Nov 22, 2024
6 checks passed
@jacomago jacomago deleted the mvn-wrapper branch November 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants