Caputlog detail page #117
Merged
Caputlog detail page #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add using caputlog check for header navigation add caputlog search layout component add new line add caputlogSearchConfig require proptypes
conorschofield
force-pushed
the
caputlog-page
branch
from
c06a833 to
0fd4c51
Compare
fix date filter
conorschofield
force-pushed
the
caputlog-page
branch
from
b138595 to
2bebb84
Compare
tynanford
reviewed
Aug 6, 2025
Contributor
tynanford
left a comment
tynanford
left a comment
There was a problem hiding this comment.
Looks really nice!
A few other general comments
- I would rather structure caputlogtable as a directory under components since it is a separate component from things on the pv details page. But if that messes up imports then it's not a big problem
- I noticed some caputs in our table to the .PROC field of a PV which is nice to see. But they don't show up in the caputlog table for that individual PV. I wonder if the PV details caputlog page could search for both
pvnameandpvname.*to catch all changes to the EPICS dot fields - allowing wildcard PV name searches would be useful
| import CalendarMonthIcon from '@mui/icons-material/CalendarMonth'; | ||
| import DatePicker from "react-datepicker"; | ||
| import "react-datepicker/dist/react-datepicker.css"; | ||
| import "@elastic/react-search-ui-views/lib/styles/styles.css"; |
Contributor
There was a problem hiding this comment.
this is really nitpicky so I can work on it in a separate PR. But I would rather have the search button and fonts match the styling of the rest of PV Info
Collaborator
Author
There was a problem hiding this comment.
I've started a CaputLogSearchLayout.css to match the current styling of the rest of PV info, it is still a bit of a work in progress but it is matching better now.
| {showSearchBox && ( | ||
| <SearchBox inputProps={{ placeholder: "Search by PV Name, User, or Client" }} /> | ||
| )} | ||
| <DatePicker |
Contributor
There was a problem hiding this comment.
it might be nice to have a clear button for the date picker to reset it back to no date range
Collaborator
Author
There was a problem hiding this comment.
I've added this in the most recent commit
Collaborator
Author
I've fixed the second point. I'm still working on restructuring caputlogtable as a directory under components |
update search css, add date clear button added initial search wildcard to caputlog accordian to search for pvName* to include searching for pvs with sufixes restructure caputlog page to be a directory under components
conorschofield
force-pushed
the
caputlog-page
branch
from
e950bc5 to
71f7522
Compare
Collaborator
Author
|
add custom elasticsearch connector for * functionality. This will allow for * wildcard at the end of the search. Still working on implementing * as a wildcard anywhere in the search string. use optional chain expression fix date filter when searchTerm is used remove unused initialSearchTerm and setSearch remove console log statements update caputlog search to work with * wildcard fix caputlog prefix .* search, update examples fix caputlog prefix .* search and update example screenshots
conorschofield
force-pushed
the
caputlog-page
branch
from
d91ed6c to
bf9082e
Compare
|
Contributor
|
Really nice, much better than having to open kibana! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add caput log detail page: