-
Notifications
You must be signed in to change notification settings - Fork 26
Support local inverters #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Poshy163 am I right that this pull request is using a local testing copy of the library? It would be better if we could update the library first and then push a version of the integration that uses the updated library. |
|
Haha yeah it is, I'm just using it atm incase I need any little changes and dont wanna push a dependency update. I'll let you know when it's ready to merge and clean up this PR after |
|
Hi @Poshy163 are you ready to have this merged or are there still more changes to come? |
|
little more changes i think, more just cleaning up some of the code + adding documentation |
|
This is excellent, well done to all involved. |
|
@CharlesGillanders good to go, ill draft up release notes once this is merged. Not sure how unique each of the local endpoints are (devinfo and status) between each inverter, but knowing alpha, it could be wildly different, ive got code within the coordinator to handle for that, so will just have to see how it goes |
It's completely @Poshy163 work so all credit should go to him. |
Ok that's done - the release is over to you to finish. |


Uh oh!
There was an error while loading. Please reload this page.