Fix Unknown Error Occurred during setup #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes an instantiation issue where the AlphaESS client class wasn’t referenced correctly, leading to an unknown error during setup.
- Updates the
validate_inputfunction to instantiate thealphaessclient from the module rather than calling the module itself. - Restores correct client authentication behavior.
Comments suppressed due to low confidence (1)
custom_components/alphaess/config_flow.py:28
- This update fixes the client instantiation logic, but there aren't any unit tests covering
validate_input. Consider adding tests to verify that the correct client is instantiated andauthenticate()is called with valid inputs.
client = alphaess.alphaess(data["AppID"], data["AppSecret"], ipaddress=data["IPAddress"])
CharlesGillanders
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
Wasn't fixed when moving over from using my custom class during testing and was never swapped back