[codex] Fix Deezer crypto import mismatch#57
Open
gaoyifan wants to merge 1 commit intoCharlesPikachu:masterfrom
Open
[codex] Fix Deezer crypto import mismatch#57gaoyifan wants to merge 1 commit intoCharlesPikachu:masterfrom
gaoyifan wants to merge 1 commit intoCharlesPikachu:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a startup-time import crash in the Deezer utility module by aligning its cryptography imports with the project’s declared pycryptodome dependency (Crypto.* namespace), resolving issue #56 where the CLI failed during eager module import.
Changes:
- Replace
Cryptodome.Cipherimports withCrypto.Cipherindeezerutils.pyto matchpycryptodome. - Prevent
ModuleNotFoundError: No module named 'Cryptodome'on CLI startup when modules are imported eagerly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CryptodometoCryptopycryptodomedependency and the rest of the codebasemusicdlimports all source modules eagerlyRoot Cause
requirements.txtdeclarespycryptodome, which exposes theCrypto.*namespace.deezerutils.pyimportedCryptodome.*instead, so the CLI crashed during module import before it could honor the user-selected music sources.Fixes #56.
Validation
uvx musicdl --versionreproduced theModuleNotFoundError: No module named 'Cryptodome'failure before the patchuvx --from /Users/yifan/tmp/tmp/repo musicdl --versionsucceeds after the patch