feat: implement safe person retrieval with caching in Webex API inter…#2
Merged
ChristopherJHart merged 2 commits intomainfrom Jul 27, 2025
Merged
feat: implement safe person retrieval with caching in Webex API inter…#2ChristopherJHart merged 2 commits intomainfrom
ChristopherJHart merged 2 commits intomainfrom
Conversation
…actions * Added a new function `safe_get_person` to fetch person details while handling deleted users gracefully. * Introduced caching for person lookups to minimize repeated API calls for deleted users. * Updated `create_message` function to utilize the new `safe_get_person` for improved error handling and efficiency.
ChristopherJHart
approved these changes
Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛡️ Description
This pull request fixes a critical bug where the Webex summarizer would crash when encountering messages from deleted or deactivated users. The fix implements graceful error handling to ensure the summarizer continues operating even when historical data references users who no longer exist in the Webex system.
🔗 Related Issue(s)
No related issues.
✔️ Type of Change
[x] 🐛 Bug fix (non-breaking change which fixes an issue)
[x] 🛠️ Refactoring/Technical debt (internal code improvements with no direct user-facing changes)
🎯 Key Changes & Implementation Details
summarizer/webex.py:🧪 Testing Done
✅ Checklist
🖼️ Error Before Fix
➡️ Next Steps (if applicable)
Consider adding a summary at the end showing count of messages from deleted users
Could extend pattern to handle other deleted entities (rooms, etc.) if needed
❓ Questions & Open Items (if applicable)
N/A