-
Notifications
You must be signed in to change notification settings - Fork 832
Add unit tests for utility functions #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PeterDaveHello
wants to merge
13
commits into
master
Choose a base branch
from
add-util-unit-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
78d0513
Add unit tests for utility functions
google-labs-jules[bot] e456cd2
Add unit tests for utility functions and fix linting issues
google-labs-jules[bot] f2203c1
Refactor tests and fix issues based on review feedback
google-labs-jules[bot] c89a6d2
Improve test coverage for model-name-convert.mjs
google-labs-jules[bot] 165254a
Fix linting, address PR feedback, and improve test coverage
google-labs-jules[bot] 80710b7
Refactor tests for robustness and address PR feedback
google-labs-jules[bot] d85bbb1
Finalize test refactoring and address all PR feedback
google-labs-jules[bot] 5e42bf0
I've addressed the final PR feedback and ensured test robustness.
google-labs-jules[bot] 39a61b2
I've addressed the PR feedback, improved tests, and noted remaining m…
google-labs-jules[bot] cc3dc63
I've addressed the latest PR feedback, with a note on `model-name-con…
google-labs-jules[bot] 3bb403e
I've addressed the final PR feedback items and wanted to give you an …
google-labs-jules[bot] 1b57db4
I've fixed a 'no-unused-vars' linting error in `model-name-convert.te…
google-labs-jules[bot] 68f2fed
Fix: Resolve no-unused-vars for modelNameToApiMode in tests
google-labs-jules[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,224 @@ | ||
body, html { | ||
margin:0; padding: 0; | ||
height: 100%; | ||
} | ||
body { | ||
font-family: Helvetica Neue, Helvetica, Arial; | ||
font-size: 14px; | ||
color:#333; | ||
} | ||
.small { font-size: 12px; } | ||
*, *:after, *:before { | ||
-webkit-box-sizing:border-box; | ||
-moz-box-sizing:border-box; | ||
box-sizing:border-box; | ||
} | ||
h1 { font-size: 20px; margin: 0;} | ||
h2 { font-size: 14px; } | ||
pre { | ||
font: 12px/1.4 Consolas, "Liberation Mono", Menlo, Courier, monospace; | ||
margin: 0; | ||
padding: 0; | ||
-moz-tab-size: 2; | ||
-o-tab-size: 2; | ||
tab-size: 2; | ||
} | ||
a { color:#0074D9; text-decoration:none; } | ||
a:hover { text-decoration:underline; } | ||
.strong { font-weight: bold; } | ||
.space-top1 { padding: 10px 0 0 0; } | ||
.pad2y { padding: 20px 0; } | ||
.pad1y { padding: 10px 0; } | ||
.pad2x { padding: 0 20px; } | ||
.pad2 { padding: 20px; } | ||
.pad1 { padding: 10px; } | ||
.space-left2 { padding-left:55px; } | ||
.space-right2 { padding-right:20px; } | ||
.center { text-align:center; } | ||
.clearfix { display:block; } | ||
.clearfix:after { | ||
content:''; | ||
display:block; | ||
height:0; | ||
clear:both; | ||
visibility:hidden; | ||
} | ||
.fl { float: left; } | ||
@media only screen and (max-width:640px) { | ||
.col3 { width:100%; max-width:100%; } | ||
.hide-mobile { display:none!important; } | ||
} | ||
|
||
.quiet { | ||
color: #7f7f7f; | ||
color: rgba(0,0,0,0.5); | ||
} | ||
.quiet a { opacity: 0.7; } | ||
|
||
.fraction { | ||
font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace; | ||
font-size: 10px; | ||
color: #555; | ||
background: #E8E8E8; | ||
padding: 4px 5px; | ||
border-radius: 3px; | ||
vertical-align: middle; | ||
} | ||
|
||
div.path a:link, div.path a:visited { color: #333; } | ||
table.coverage { | ||
border-collapse: collapse; | ||
margin: 10px 0 0 0; | ||
padding: 0; | ||
} | ||
|
||
table.coverage td { | ||
margin: 0; | ||
padding: 0; | ||
vertical-align: top; | ||
} | ||
table.coverage td.line-count { | ||
text-align: right; | ||
padding: 0 5px 0 20px; | ||
} | ||
table.coverage td.line-coverage { | ||
text-align: right; | ||
padding-right: 10px; | ||
min-width:20px; | ||
} | ||
|
||
table.coverage td span.cline-any { | ||
display: inline-block; | ||
padding: 0 5px; | ||
width: 100%; | ||
} | ||
.missing-if-branch { | ||
display: inline-block; | ||
margin-right: 5px; | ||
border-radius: 3px; | ||
position: relative; | ||
padding: 0 4px; | ||
background: #333; | ||
color: yellow; | ||
} | ||
|
||
.skip-if-branch { | ||
display: none; | ||
margin-right: 10px; | ||
position: relative; | ||
padding: 0 4px; | ||
background: #ccc; | ||
color: white; | ||
} | ||
.missing-if-branch .typ, .skip-if-branch .typ { | ||
color: inherit !important; | ||
} | ||
.coverage-summary { | ||
border-collapse: collapse; | ||
width: 100%; | ||
} | ||
.coverage-summary tr { border-bottom: 1px solid #bbb; } | ||
.keyline-all { border: 1px solid #ddd; } | ||
.coverage-summary td, .coverage-summary th { padding: 10px; } | ||
.coverage-summary tbody { border: 1px solid #bbb; } | ||
.coverage-summary td { border-right: 1px solid #bbb; } | ||
.coverage-summary td:last-child { border-right: none; } | ||
.coverage-summary th { | ||
text-align: left; | ||
font-weight: normal; | ||
white-space: nowrap; | ||
} | ||
.coverage-summary th.file { border-right: none !important; } | ||
.coverage-summary th.pct { } | ||
.coverage-summary th.pic, | ||
.coverage-summary th.abs, | ||
.coverage-summary td.pct, | ||
.coverage-summary td.abs { text-align: right; } | ||
.coverage-summary td.file { white-space: nowrap; } | ||
.coverage-summary td.pic { min-width: 120px !important; } | ||
.coverage-summary tfoot td { } | ||
|
||
.coverage-summary .sorter { | ||
height: 10px; | ||
width: 7px; | ||
display: inline-block; | ||
margin-left: 0.5em; | ||
background: url(sort-arrow-sprite.png) no-repeat scroll 0 0 transparent; | ||
} | ||
.coverage-summary .sorted .sorter { | ||
background-position: 0 -20px; | ||
} | ||
.coverage-summary .sorted-desc .sorter { | ||
background-position: 0 -10px; | ||
} | ||
.status-line { height: 10px; } | ||
/* yellow */ | ||
.cbranch-no { background: yellow !important; color: #111; } | ||
/* dark red */ | ||
.red.solid, .status-line.low, .low .cover-fill { background:#C21F39 } | ||
.low .chart { border:1px solid #C21F39 } | ||
.highlighted, | ||
.highlighted .cstat-no, .highlighted .fstat-no, .highlighted .cbranch-no{ | ||
background: #C21F39 !important; | ||
} | ||
/* medium red */ | ||
.cstat-no, .fstat-no, .cbranch-no, .cbranch-no { background:#F6C6CE } | ||
/* light red */ | ||
.low, .cline-no { background:#FCE1E5 } | ||
/* light green */ | ||
.high, .cline-yes { background:rgb(230,245,208) } | ||
/* medium green */ | ||
.cstat-yes { background:rgb(161,215,106) } | ||
/* dark green */ | ||
.status-line.high, .high .cover-fill { background:rgb(77,146,33) } | ||
.high .chart { border:1px solid rgb(77,146,33) } | ||
/* dark yellow (gold) */ | ||
.status-line.medium, .medium .cover-fill { background: #f9cd0b; } | ||
.medium .chart { border:1px solid #f9cd0b; } | ||
/* light yellow */ | ||
.medium { background: #fff4c2; } | ||
|
||
.cstat-skip { background: #ddd; color: #111; } | ||
.fstat-skip { background: #ddd; color: #111 !important; } | ||
.cbranch-skip { background: #ddd !important; color: #111; } | ||
|
||
span.cline-neutral { background: #eaeaea; } | ||
|
||
.coverage-summary td.empty { | ||
opacity: .5; | ||
padding-top: 4px; | ||
padding-bottom: 4px; | ||
line-height: 1; | ||
color: #888; | ||
} | ||
|
||
.cover-fill, .cover-empty { | ||
display:inline-block; | ||
height: 12px; | ||
} | ||
.chart { | ||
line-height: 0; | ||
} | ||
.cover-empty { | ||
background: white; | ||
} | ||
.cover-full { | ||
border-right: none !important; | ||
} | ||
pre.prettyprint { | ||
border: none !important; | ||
padding: 0 !important; | ||
margin: 0 !important; | ||
} | ||
.com { color: #999 !important; } | ||
.ignore-none { color: #999; font-weight: normal; } | ||
|
||
.wrapper { | ||
min-height: 100%; | ||
height: auto !important; | ||
height: 100%; | ||
margin: 0 auto -48px; | ||
} | ||
.footer, .push { | ||
height: 48px; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
/* eslint-disable */ | ||
var jumpToCode = (function init() { | ||
// Classes of code we would like to highlight in the file view | ||
var missingCoverageClasses = ['.cbranch-no', '.cstat-no', '.fstat-no']; | ||
|
||
// Elements to highlight in the file listing view | ||
var fileListingElements = ['td.pct.low']; | ||
|
||
// We don't want to select elements that are direct descendants of another match | ||
var notSelector = ':not(' + missingCoverageClasses.join('):not(') + ') > '; // becomes `:not(a):not(b) > ` | ||
|
||
// Selecter that finds elements on the page to which we can jump | ||
var selector = | ||
fileListingElements.join(', ') + | ||
', ' + | ||
notSelector + | ||
missingCoverageClasses.join(', ' + notSelector); // becomes `:not(a):not(b) > a, :not(a):not(b) > b` | ||
|
||
// The NodeList of matching elements | ||
var missingCoverageElements = document.querySelectorAll(selector); | ||
|
||
var currentIndex; | ||
|
||
function toggleClass(index) { | ||
missingCoverageElements | ||
.item(currentIndex) | ||
.classList.remove('highlighted'); | ||
missingCoverageElements.item(index).classList.add('highlighted'); | ||
} | ||
|
||
function makeCurrent(index) { | ||
toggleClass(index); | ||
currentIndex = index; | ||
missingCoverageElements.item(index).scrollIntoView({ | ||
behavior: 'smooth', | ||
block: 'center', | ||
inline: 'center' | ||
}); | ||
} | ||
|
||
function goToPrevious() { | ||
var nextIndex = 0; | ||
if (typeof currentIndex !== 'number' || currentIndex === 0) { | ||
nextIndex = missingCoverageElements.length - 1; | ||
} else if (missingCoverageElements.length > 1) { | ||
nextIndex = currentIndex - 1; | ||
} | ||
|
||
makeCurrent(nextIndex); | ||
} | ||
|
||
function goToNext() { | ||
var nextIndex = 0; | ||
|
||
if ( | ||
typeof currentIndex === 'number' && | ||
currentIndex < missingCoverageElements.length - 1 | ||
) { | ||
nextIndex = currentIndex + 1; | ||
} | ||
|
||
makeCurrent(nextIndex); | ||
} | ||
|
||
return function jump(event) { | ||
if ( | ||
document.getElementById('fileSearch') === document.activeElement && | ||
document.activeElement != null | ||
) { | ||
// if we're currently focused on the search input, we don't want to navigate | ||
return; | ||
} | ||
|
||
switch (event.which) { | ||
case 78: // n | ||
case 74: // j | ||
goToNext(); | ||
break; | ||
case 66: // b | ||
case 75: // k | ||
case 80: // p | ||
goToPrevious(); | ||
break; | ||
} | ||
}; | ||
})(); | ||
window.addEventListener('keydown', jumpToCode); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.