Skip to content

fix: avoid crash when readability parser returns null #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2025
Merged

fix: avoid crash when readability parser returns null #865

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f9286c
fix: avoid crash when readability parser returns null
PeterDaveHello Jun 7, 2025
a29ca8d
Update src/utils/get-core-content-text.mjs
PeterDaveHello Jun 7, 2025
5179a19
Update src/utils/get-core-content-text.mjs
PeterDaveHello Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/utils/get-core-content-text.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,13 @@ export function getCoreContentText() {
}

if (isProbablyReaderable(document)) {
let article = new Readability(document.cloneNode(true), {
const article = new Readability(document.cloneNode(true), {
keepClasses: true,
}).parse()
console.log('readerable')
return postProcessText(article.textContent)
if (article?.textContent) {
console.log('readerable')
return postProcessText(article.textContent)
}
}

const largestElement = findLargestElement(document.body)
Expand Down