Skip to content

feat: use llm icon for exporter#6196

Closed
Eric-2369 wants to merge 1 commit intoChatGPTNextWeb:mainfrom
Eric-2369:use-llm-icon-for-exporter
Closed

feat: use llm icon for exporter#6196
Eric-2369 wants to merge 1 commit intoChatGPTNextWeb:mainfrom
Eric-2369:use-llm-icon-for-exporter

Conversation

@Eric-2369
Copy link
Contributor

@Eric-2369 Eric-2369 commented Feb 10, 2025

💻 变更类型 | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

🔀 变更说明 | Description of Change

为 exporter 中 ImagePreviewer 模块添加了显示更多 llm icons 的支持
移除了无用的 ExportAvatar
更新了导出图片中的项目地址

📝 补充信息 | Additional Information

Summary by CodeRabbit

  • Refactor
    • Streamlined the chat interface by integrating avatar rendering directly, ensuring a consistent display for both user and bot.
  • Documentation
    • Updated the chat information section with a new GitHub repository link for enhanced reference.

@vercel
Copy link

vercel bot commented Feb 10, 2025

@Eric-2369 is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2025

Walkthrough

This update removes the separate ExportAvatar function from the exporter file and integrates its logic directly into the ImagePreviewer component. The ImagePreviewer now performs conditional checks to render avatars using the Avatar component based on the message role. Additionally, the chat information subtitle has been updated to include a new GitHub repository link. The changes simplify the code by consolidating avatar rendering into one component, reducing redundancy.

Changes

File Change Summary
app/components/.../exporter.tsx Removed the ExportAvatar function; integrated avatar rendering directly inside the ImagePreviewer component; updated conditional logic to use the Avatar component; revised chat subtitle with a new GitHub link.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant IP as ImagePreviewer
  participant A as Avatar

  U->>IP: Send message event
  IP->>IP: Check message role
  alt User Message
      IP->>A: Render user avatar
  else Bot Message
      IP->>A: Render bot avatar
  end
  A-->>IP: Return rendered avatar
  IP-->>U: Display message with avatar
Loading

Poem

Hop, skip, and a bound so free,
I saw the code change, a joy to see!
No more ExportAvatar hiding away,
Now ImagePreviewer saves the day.
With a twitch of my nose and a happy heart,
I'm a rabbit celebrating this code art!
🐇🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Eric-2369 Eric-2369 mentioned this pull request Feb 10, 2025
10 tasks
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
app/components/exporter.tsx (2)

529-529: Add protocol prefix to GitHub URL.

Consider adding the 'https://' prefix to make the URL clickable in more contexts.

-              github.com/ChatGPTNextWeb/NextChat
+              https://github.com/ChatGPTNextWeb/NextChat

566-572: Extract avatar rendering logic into a reusable component.

The avatar rendering logic is duplicated from the chat info section. Consider extracting it into a separate component to improve maintainability.

+const MessageAvatar = ({ role, config, mask }) => {
+  if (role === "user") {
+    return <Avatar avatar={config.avatar} />;
+  }
+  return mask.avatar === DEFAULT_MASK_AVATAR ? (
+    <Avatar model={mask.modelConfig.model} />
+  ) : (
+    <Avatar avatar={mask.avatar} />
+  );
+};

 <div className={styles["avatar"]}>
-  {m.role === "user" ? (
-    <Avatar avatar={config.avatar} />
-  ) : mask.avatar === DEFAULT_MASK_AVATAR ? (
-    <Avatar model={m.model} />
-  ) : (
-    <Avatar avatar={mask.avatar} />
-  )}
+  <MessageAvatar role={m.role} config={config} mask={mask} />
 </div>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a029b43 and e31f452.

📒 Files selected for processing (1)
  • app/components/exporter.tsx (2 hunks)
🔇 Additional comments (1)
app/components/exporter.tsx (1)

532-538: LGTM! Clean implementation of avatar rendering.

The conditional rendering logic effectively handles both default model icons and custom avatars.

@Eric-2369 Eric-2369 closed this Feb 12, 2025
@Eric-2369 Eric-2369 deleted the use-llm-icon-for-exporter branch February 12, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments