Skip to content
This repository was archived by the owner on Jan 6, 2026. It is now read-only.

Add linter#22

Merged
juliangruber merged 7 commits intomainfrom
add/lint
Jan 23, 2025
Merged

Add linter#22
juliangruber merged 7 commits intomainfrom
add/lint

Conversation

@juliangruber
Copy link
Member

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 21, 2025

Deploying spark-dashboard with  Cloudflare Pages  Cloudflare Pages

Latest commit: 42f19c3
Status: ✅  Deploy successful!
Preview URL: https://9ed7e219.spark-dashboard.pages.dev
Branch Preview URL: https://add-lint.spark-dashboard.pages.dev

View logs

@juliangruber juliangruber changed the title Add JS linter Add linter Jan 21, 2025
@juliangruber
Copy link
Member Author

I switched from standard to prettier as I couldn't get eslint markdown listing to work with the YAML frontmatter we use

Copy link
Member

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏻

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love adopting a linter that's more opinionated about formatting.

At the same time, we haven't agreed that Prettier is the tool we want to use.

I am a bit reluctant to use different linters in different repositories.

Let's discuss.

@juliangruber juliangruber requested a review from bajtos January 22, 2025 08:08
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@juliangruber juliangruber merged commit 0cd531d into main Jan 23, 2025
3 checks passed
@juliangruber juliangruber deleted the add/lint branch January 23, 2025 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants