This repository was archived by the owner on Jan 6, 2026. It is now read-only.
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/index.md:54
- The 'total' field is converted to a BigInt, which may cause unexpected behavior when sorting or displaying the value if the table expects a Number. Consider converting to a Number or providing a formatting function that handles BigInt appropriately.
total: BigInt(record.total),
Deploying spark-dashboard with
|
| Latest commit: |
301dafd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c1eb5d7a.spark-dashboard.pages.dev |
| Branch Preview URL: | https://fix-table-sorting.spark-dashboard.pages.dev |
Member
Author
juliangruber
approved these changes
Apr 15, 2025
Member
juliangruber
left a comment
juliangruber
left a comment
There was a problem hiding this comment.
If it looks right, I trust this PR to be good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes sorting values inside dashboard tables. Fix is achieved by converting all sortable values to number and keeping as numerical values, formatting them inside of the
Inputs.tableelement.I have opted for
Numberinstead of theBigIntfortotalvalue as we're using integers on the database level rather then big integers.Closes #17