This repository was archived by the owner on Jan 7, 2026. It is now read-only.
Merged
Conversation
```
lib/storacha.js:12:20 - error TS2345: Argument of type 'Block[]' is not assignable to parameter of type 'Iterable<Block<unknown, number, number, 1>>'.
The types returned by '[Symbol.iterator]().next(...)' are incompatible between these types.
Type 'IteratorResult<Block, any>' is not assignable to type 'IteratorResult<Block<unknown, number, number, 1>, any>'.
Type 'IteratorYieldResult<Block>' is not assignable to type 'IteratorResult<Block<unknown, number, number, 1>, any>'.
Type 'IteratorYieldResult<Block>' is not assignable to type 'IteratorYieldResult<Block<unknown, number, number, 1>>'.
Type 'Block' is not assignable to type 'Block<unknown, number, number, 1>'.
The types of 'cid.version' are incompatible between these types.
Type 'Version' is not assignable to type '1'.
Type '0' is not assignable to type '1'.
12 return importDAG(blocks)
```
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
commented
Aug 6, 2025
Comment on lines
+6
to
+13
| /** | ||
| * @param {string} data | ||
| */ | ||
| async function parseProof (data) { | ||
| // Casting to unsafe `any[]` to avoid the following TypeScript error: | ||
| // Argument of type 'Block[]' is not assignable to parameter | ||
| // of type 'Iterable<Block<unknown, number, number, 1>>' | ||
| /** @type {any[]} */ |
Member
Author
There was a problem hiding this comment.
This is the same fix I proposed in spark-api too, see https://github.com/CheckerNetwork/spark-api/pull/687/files#diff-6fd94430644d1de0092d76b85be7792f813c95bf3204049fa99fe3352463e90eR32-R39
pyropy
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following error: