Skip to content
This repository was archived by the owner on Jan 7, 2026. It is now read-only.

fix: skip downloading CIDs for empty files#617

Merged
pyropy merged 1 commit intomainfrom
support-empty-batch
Aug 7, 2025
Merged

fix: skip downloading CIDs for empty files#617
pyropy merged 1 commit intomainfrom
support-empty-batch

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented Aug 6, 2025

Some CIDs represent an empty file and Storacha returns HTTP 410 Gone error response in such case.

In this patch, I am fixing the function fetchMeasurements to skip the retrieval and return an empty list for such CIDs.

See also:

Some CIDs represent an empty file and Storacha returns HTTP 410 Gone
error response in such case.

In this patch, I am fixing the function `fetchMeasurements` to
skip the retrieval and return an empty list for such CIDs.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos
Copy link
Member Author

bajtos commented Aug 6, 2025

From the logs:

2025-08-06T16:50:32Z app[e2867541be3e68] cdg [info]Now preprocessing measurements for CID bafkqaaa in round 37443
2025-08-06T16:50:32Z app[e2867541be3e68] cdg [info]PREPROCESS ROUND 37443n: Added measurements from CID bafkqaaa
2025-08-06T16:50:32Z app[e2867541be3e68] cdg [info]{ total: 0, valid: 0 }
2025-08-06T16:50:32Z app[e2867541be3e68] cdg [info]Retrieval Success Rate: NaN% (0 of 0)

@pyropy pyropy merged commit 6a7cf29 into main Aug 7, 2025
6 checks passed
@pyropy pyropy deleted the support-empty-batch branch August 7, 2025 07:58
@github-project-automation github-project-automation bot moved this to ✅ done in CheckerNetwork Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: ✅ done

Development

Successfully merging this pull request may close these issues.

2 participants