-
Notifications
You must be signed in to change notification settings - Fork 1
FIX:implemented depenabot #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
implemented depenabot for both npm and github-action packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR 🎉
Could you also add me (@pyropy) and @NikolasHaimerl to reviewers? 🙏🏻
|
You are welconme, i have added pyropy and NikolasHaimerl as reviewers as requested |
|
Awesome @Goddhi! 🚀 Would you mind adding other dependabot related script, like the ones found in spark-stats repository? |
|
I've added the script you mentioned, along with the Dependabot auto-merge script. Let me know if you'd like me to replicate it across all CheckerNetwork repositories that use Dependabot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're almost there, good job 👏🏻
| strategy: | ||
| matrix: | ||
| dependencyStartsWith: | ||
| - '@sentry/' | ||
| - mocha | ||
| - pg | ||
| - debug | ||
| - ethers | ||
| - typescript | ||
| - postgrator | ||
| - '@types/' | ||
| - standard | ||
| - cross-spawn | ||
| - '@filecoin-station/spark-impact-evaluator' | ||
| - '@fastify/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| strategy: | |
| matrix: | |
| dependencyStartsWith: | |
| - '@sentry/' | |
| - mocha | |
| - pg | |
| - debug | |
| - ethers | |
| - typescript | |
| - postgrator | |
| - '@types/' | |
| - standard | |
| - cross-spawn | |
| - '@filecoin-station/spark-impact-evaluator' | |
| - '@fastify/' |
As we're not using these dependencies inside this project I suggest we delete them or replace them, otherwise auto-approve script won't pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, i have updated the auto approve script to use the right dependencies based on the package.json file.
Kindly check it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job @Goddhi, we're almost there. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! Thank you for contributing 🫶
implemented depenabot for both npm and github-action packages.