Skip to content

Conversation

@Goddhi
Copy link

@Goddhi Goddhi commented Feb 23, 2025

implemented depenabot for both npm and github-action packages.

implemented depenabot for both npm and github-action packages
@Goddhi Goddhi requested a review from pyropy as a code owner February 23, 2025 10:56
Copy link
Member

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR 🎉

Could you also add me (@pyropy) and @NikolasHaimerl to reviewers? 🙏🏻

@Goddhi
Copy link
Author

Goddhi commented Feb 24, 2025

You are welconme, i have added pyropy and NikolasHaimerl as reviewers as requested

@pyropy
Copy link
Member

pyropy commented Feb 25, 2025

Awesome @Goddhi! 🚀

Would you mind adding other dependabot related script, like the ones found in spark-stats repository?
Note: We'd like to use this dependabot-auto-merge.yml script.

@Goddhi
Copy link
Author

Goddhi commented Feb 26, 2025

I've added the script you mentioned, along with the Dependabot auto-merge script. Let me know if you'd like me to replicate it across all CheckerNetwork repositories that use Dependabot.

Copy link
Member

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're almost there, good job 👏🏻

Comment on lines 11 to 25
strategy:
matrix:
dependencyStartsWith:
- '@sentry/'
- mocha
- pg
- debug
- ethers
- typescript
- postgrator
- '@types/'
- standard
- cross-spawn
- '@filecoin-station/spark-impact-evaluator'
- '@fastify/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
strategy:
matrix:
dependencyStartsWith:
- '@sentry/'
- mocha
- pg
- debug
- ethers
- typescript
- postgrator
- '@types/'
- standard
- cross-spawn
- '@filecoin-station/spark-impact-evaluator'
- '@fastify/'

As we're not using these dependencies inside this project I suggest we delete them or replace them, otherwise auto-approve script won't pass.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i have updated the auto approve script to use the right dependencies based on the package.json file.
Kindly check it out.

Copy link
Member

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @Goddhi, we're almost there. 🚀

Copy link
Member

@pyropy pyropy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! Thank you for contributing 🫶

@pyropy pyropy merged commit 2bf4724 into CheckerNetwork:main Mar 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants