feat: guarantee that line number obtained by git and filesystem allows the secrets to be correlated #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed unit tests for this function
cx-rui-oliveira
changed the title
|
KICS version: v1.7.13
|
cx-rui-oliveira
changed the title
|
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
Policy Management Violations (1)
|
cx-leonardo-fontes
approved these changes
May 7, 2025
cx-rui-oliveira
deleted the
AST-93087-backend-2-ms-guarantee-that-line-number-obtained-by-git-and-filesystem-allows-the-secrets-to-be-correlated
branch
cx-rogerio-dalot
pushed a commit
that referenced
this pull request
Sep 11, 2025
…s the secrets to be correlated (#286) **Proposed Changes** To correlate secrets detected by git and the file system, the 2ms git scan now returns the start and end lines where the secret was detected with the file as reference instead of the related git diff. **Checklist** - [x] I covered my changes with tests. - [ ] I Updated the documentation that is affected by my changes: - [ ] Change in the CLI arguments - [ ] Change in the configuration file --------- Co-authored-by: Leonardo Fontes <[email protected]> Co-authored-by: LeonardoLordelloFontes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
To correlate secrets detected by git and the file system, the 2ms git scan now returns the start and end lines where the secret was detected with the file as reference instead of the related git diff.
Checklist