fix: use line relative to file instead of relative to chunk#291
Merged
cx-rui-oliveira merged 4 commits intomasterfrom May 30, 2025
Merged
fix: use line relative to file instead of relative to chunk#291cx-rui-oliveira merged 4 commits intomasterfrom
cx-rui-oliveira merged 4 commits intomasterfrom
Conversation
|
KICS version: v1.7.13
|
|
Great job, no security vulnerabilities found in this Pull Request |
cx-rui-oliveira
force-pushed
the
fix-lines-with-chunking
branch
from
61230c9 to
e5d2b8f
Compare
cx-rogerio-dalot
previously approved these changes
May 27, 2025
cx-rogerio-dalot
approved these changes
May 30, 2025
cx-rogerio-dalot
pushed a commit
that referenced
this pull request
Sep 11, 2025
**Proposed Changes** - Fixed start and end line of secret when chunking is used - Instead of calculating the line taking into account only the chunk, it also considers the context of the file. At the moment, we use context variables to pass on information about the lines in the chunks, **but this is a temporary solution until the engine instance is restructured**. **Checklist** - [ ] I covered my changes with tests. - [ ] I Updated the documentation that is affected by my changes: - [ ] Change in the CLI arguments - [ ] Change in the configuration file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist