Skip to content

fix: use line relative to file instead of relative to chunk #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cx-rui-oliveira merged 4 commits into from
May 30, 2025
Merged

fix: use line relative to file instead of relative to chunk #291

cx-rui-oliveira merged 4 commits into from
May 30, 2025
+34 −15

Conversation

@cx-rui-oliveira
Copy link
Contributor

@cx-rui-oliveira cx-rui-oliveira commented May 26, 2025 •
edited
Loading

Proposed Changes

  • Fixed start and end line of secret when chunking is used
    • Instead of calculating the line taking into account only the chunk, it also considers the context of the file. At the moment, we use context variables to pass on information about the lines in the chunks, but this is a temporary solution until the engine instance is restructured.

Checklist

  • I covered my changes with tests.
  • I Updated the documentation that is affected by my changes:
    • Change in the CLI arguments
    • Change in the configuration file

@cx-rui-oliveira cx-rui-oliveira requested a review from a team as a code owner May 26, 2025 15:13
@github-actions
Copy link

github-actions bot commented May 26, 2025

kics-logo

KICS version: v1.7.13

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 11
Files parsed placeholder 11
Files failed to scan placeholder 0
Total executed queries placeholder 53
Queries failed to execute placeholder 0
Execution time placeholder 1

@github-actions
Copy link

github-actions bot commented May 26, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 6b59fa2d-359d-4b80-94de-f08bc9f77c54

Great job, no security vulnerabilities found in this Pull Request

@cx-rui-oliveira cx-rui-oliveira force-pushed the fix-lines-with-chunking branch from 61230c9 to e5d2b8f Compare May 26, 2025 17:32
cx-rogerio-dalot
cx-rogerio-dalot reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@cx-rogerio-dalot cx-rogerio-dalot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cx-rui-oliveira cx-rui-oliveira merged commit b6d76f8 into master May 30, 2025
13 of 14 checks passed
@cx-rui-oliveira cx-rui-oliveira deleted the fix-lines-with-chunking branch May 30, 2025 11:29
cx-rogerio-dalot pushed a commit that referenced this pull request Sep 11, 2025
@cx-rui-oliveira
fix: use line relative to file instead of relative to chunk (#291)
0f81e43 
**Proposed Changes**

- Fixed start and end line of secret when chunking is used 
- Instead of calculating the line taking into account only the chunk, it
also considers the context of the file. At the moment, we use context
variables to pass on information about the lines in the chunks, **but
this is a temporary solution until the engine instance is
restructured**.

**Checklist**

- [ ] I covered my changes with tests.
- [ ] I Updated the documentation that is affected by my changes:
  - [ ] Change in the CLI arguments
  - [ ] Change in the configuration file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-rogerio-dalot cx-rogerio-dalot cx-rogerio-dalot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cx-rui-oliveira @cx-rogerio-dalot