Merged
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
b7f3ada to
3a71a7c
Compare
Contributor
Author
Benchmark Analysis (10 runs each) on a CPU with 8 coresPerformance Summary50 Items - Best Performers (by mean)
100 Items - Best Performers (by mean)
500 Items - Best Performers (by mean)
1000 Items - Best Performers (by mean)
10000 Items - Best Performers (by mean)
Key InsightsBest Worker Counts (Overall Average)
|
76c6ed0 to
615d684
Compare
8c0ae9e to
71aedac
Compare
71aedac to
066f87c
Compare
de0fcec to
ca72934
Compare
d51e096 to
0db287f
Compare
1b14461 to
4f31644
Compare
7f667b8 to
d183911
Compare
cx-rui-gomes
previously approved these changes
Sep 2, 2025
cx-rui-gomes
approved these changes
Sep 9, 2025
cx-rogerio-dalot
added a commit
that referenced
this pull request
Sep 11, 2025
<!-- Thanks for contributing to 2ms by offering a pull request. --> Closes # **Proposed Changes** - It introduces a workerpool to optimize the detection which wraps around [pond](https://github.com/alitto/pond) - Initializes with a default number of workers calculated by number of CPUs x2 - Reached that conclusion with the benchmark, see my comment below with the stats. - This workerpool can be used for other purposes in next steps of the pipeline (in future PRs) - On a future PR we won't wait for the detection to end. - Fixed some linter issues <!-- Please describe the big picture of your changes here. If it fixes a bug or resolves a feature request, be sure to link to that issue. --> **Checklist** - [X] I covered my changes with tests. - [ ] I Updated the documentation that is affected by my changes: - [ ] Change in the CLI arguments - [ ] Change in the configuration file I submit this contribution under the Apache-2.0 license. --------- Co-authored-by: Rogério Dalot <206845486+cx-rogerio-dalot-x@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Closes #
Proposed Changes
Checklist
I submit this contribution under the Apache-2.0 license.