Error message for SCS and Enterprise Secret (AST-73370) #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturfalcao
requested review from
cx-ben-alvo,
cx-daniel-greenspan and
cx-miryam-foifer
as code owners
|
Great job, no security vulnerabilities found in this Pull Request |
cx-ben-alvo
previously approved these changes
Jan 16, 2025
cx-daniel-greenspan
previously approved these changes
Jan 21, 2025
…into bug/AST-73370
arturfalcao
dismissed stale reviews from cx-daniel-greenspan and cx-ben-alvo
via
d40a152
cx-daniel-greenspan
previously approved these changes
Jan 22, 2025
cx-daniel-greenspan
approved these changes
Jan 22, 2025
cx-anjali-deore
pushed a commit
that referenced
this pull request
Jul 3, 2025
Error message for SCS and Enterprise Secret (AST-73370)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of handling feature flags and allowed engines in the JWTMockWrapper and JWTStruct implementations. It includes the following changes:
Added a new mock for GetAllowedEngines to work with different engines set in tests.
Updated the GetAllowedEngines method in JWTStruct to handle feature flags and return the correct allowed engines.
Added unit tests to validate the behavior of the new mock and the updated GetAllowedEngines method.
References
Include supporting link to GitHub Issue/PR number
Testing
This change was tested by adding unit tests for the GetAllowedEngines method and the new mock implementation. The tests cover various scenarios to ensure the correct engines are returned based on the feature flags and JWT token data. All existing tests were run to ensure no regressions were introduced.