Add FF for custom states call (AST-80216) #1043
Conversation
cx-itay-paz
requested review from
cx-ben-alvo,
cx-daniel-greenspan and
cx-miryam-foifer
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| triageShowCmd := triageShowSubCommand(resultsPredicatesWrapper) | ||
| triageUpdateCmd := triageUpdateSubCommand(resultsPredicatesWrapper, featureFlagsWrapper) | ||
| triageGetStatesCmd := triageGetStatesSubCommand(customStatesWrapper) | ||
| triageGetStatesCmd := triageGetStatesSubCommand(customStatesWrapper, featureFlagsWrapper ) |
There was a problem hiding this comment.
There is an extra space before the closing parenthesis. Please remove it for consistency.
| } | ||
|
|
||
| func triageGetStatesSubCommand(customStatesWrapper wrappers.CustomStatesWrapper) *cobra.Command { | ||
| func triageGetStatesSubCommand(customStatesWrapper wrappers.CustomStatesWrapper, featureFlagsWrapper wrappers.FeatureFlagsWrapper) *cobra.Command { |
There was a problem hiding this comment.
The function signature for triageGetStatesSubCommand has been changed to include featureFlagsWrapper. Ensure that all callers of this function are updated to pass the new argument.
| `, | ||
| ), | ||
| RunE: runTriageGetStates(customStatesWrapper), | ||
| RunE: runTriageGetStates(customStatesWrapper, featureFlagsWrapper), |
There was a problem hiding this comment.
The featureFlagsWrapper parameter is added to the runTriageGetStates function, but the corresponding function definition and the usage within the function body are not provided in the diff. Ensure that the function definition is updated to accept this new parameter and that it is utilized properly within the function.
| func runTriageGetStates(customStatesWrapper wrappers.CustomStatesWrapper) func(*cobra.Command, []string) error { | ||
| func runTriageGetStates(customStatesWrapper wrappers.CustomStatesWrapper, featureFlagsWrapper wrappers.FeatureFlagsWrapper,) func(*cobra.Command, []string) error { | ||
| return func(cmd *cobra.Command, _ []string) error { | ||
| flagResponse, _ := wrappers.GetSpecificFeatureFlag(featureFlagsWrapper, wrappers.CustomStatesFeatureFlag) |
There was a problem hiding this comment.
Error handling for wrappers.GetSpecificFeatureFlag is missing. Consider handling the error to avoid ignoring potential issues when retrieving the feature flag status.
cx-itay-paz
changed the title
cx-itay-paz
changed the title
|
Great job, no security vulnerabilities found in this Pull Request |
1 participant
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist