Skip to content

Conversation

@cx-ben-alvo
Copy link
Collaborator

@cx-ben-alvo cx-ben-alvo commented Feb 12, 2025

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Ensure writeCredentialsToCache is thread-safe, Prevent multiple Goroutines from overwriting the cache inconsistently.

References

https://checkmarx.atlassian.net/browse/AST-82856

Testing

Add unit test

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

@github-actions github-actions bot added bug Something isn't working fix labels Feb 12, 2025
@cx-ben-alvo cx-ben-alvo changed the title Make writeCredentialsToCache func thread safe Make writeCredentialsToCache func thread safe (AST-82856) Feb 12, 2025
@github-actions
Copy link

github-actions bot commented Feb 12, 2025

Logo
Checkmarx One – Scan Summary & Details08e4dda1-e301-4838-8e18-bd122ecde974

Great job, no security vulnerabilities found in this Pull Request

Copy link
Contributor

@cx-elchanan-arbiv cx-elchanan-arbiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I would add logs at key points to help debug potential issues

@cx-ben-alvo cx-ben-alvo merged commit 5cea005 into main Feb 13, 2025
10 checks passed
@cx-ben-alvo cx-ben-alvo deleted the fix/benalvo/cuncurrent-map-write branch February 13, 2025 10:35
cx-anjali-deore pushed a commit that referenced this pull request Jul 3, 2025
* Make writeCredentialsToCache func thread safe

* Fix trivyy

---------

Co-authored-by: AlvoBen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants